[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 16/17] target/m68k: add the Interrupt Stack P
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v5 16/17] target/m68k: add the Interrupt Stack Pointer |
Date: |
Tue, 2 Jan 2018 19:50:39 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
Le 02/01/2018 à 18:13, Richard Henderson a écrit :
> On 01/01/2018 05:10 PM, Laurent Vivier wrote:
>> env->sr = tmp;
>> + m68k_switch_sp(env);
>
> I would much prefer a cpu_m68k_set_sr here, akin to cpu_m68k_set_ccr.
Yes, it's a good idea, I also use several times helper_set_sr()
directly, I will replace them by a cpu_m68k_set_sr().
Thanks,
Laurent
- Re: [Qemu-devel] [PATCH v5 07/17] target/m68k: add chk and chk2, (continued)
[Qemu-devel] [PATCH v5 10/17] target/m68k: add cpush/cinv, Laurent Vivier, 2018/01/01
[Qemu-devel] [PATCH v5 16/17] target/m68k: add the Interrupt Stack Pointer, Laurent Vivier, 2018/01/01
Re: [Qemu-devel] [PATCH v5 00/17] target/m68k: supervisor mode (part 1), no-reply, 2018/01/01