[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 08/17] target/m68k: add move16
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v5 08/17] target/m68k: add move16 |
Date: |
Wed, 3 Jan 2018 00:53:04 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
Le 03/01/2018 à 00:49, Richard Henderson a écrit :
> On 01/02/2018 10:42 AM, Laurent Vivier wrote:
>> Le 02/01/2018 à 17:50, Richard Henderson a écrit :
>>> On 01/01/2018 05:10 PM, Laurent Vivier wrote:
>>>> + mode = (insn >> 3) & 7;
>>>> +
>>>> + if (mode & 4) {
>>>
>>> Looks like mode should equal 4 as well.
>>>
>>
>> Yes, you're right. I will replace the line by:
>>
>> + if (mode == 4) {
>
> Well, not quite. Surely,
>
> if (mode & 4) {
> if (mode != 4) {
> illegal opcode
I've split the instruction in two parts to manage the illegal opcode in
the opcode table.
Thanks,
Laurent
- Re: [Qemu-devel] [PATCH v5 13/17] target/m68k: move CCR/SR functions, (continued)
[Qemu-devel] [PATCH v5 10/17] target/m68k: add cpush/cinv, Laurent Vivier, 2018/01/01
[Qemu-devel] [PATCH v5 16/17] target/m68k: add the Interrupt Stack Pointer, Laurent Vivier, 2018/01/01
Re: [Qemu-devel] [PATCH v5 00/17] target/m68k: supervisor mode (part 1), no-reply, 2018/01/01