[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 01/11] migration: assert colo instead of check
From: |
Peter Xu |
Subject: |
[Qemu-devel] [PATCH 01/11] migration: assert colo instead of check |
Date: |
Wed, 3 Jan 2018 13:40:33 +0800 |
When reaching here if we are still "active" it means we must be in colo
state. Assert it instead of check it in if condition.
Finally I want to use "switch" here rather than lots of complicated if
clauses.
Signed-off-by: Peter Xu <address@hidden>
---
migration/migration.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 4de3b551fe..0ee4b4c27c 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2309,7 +2309,8 @@ static void *migration_thread(void *opaque)
}
runstate_set(RUN_STATE_POSTMIGRATE);
} else {
- if (s->state == MIGRATION_STATUS_ACTIVE && enable_colo) {
+ if (s->state == MIGRATION_STATUS_ACTIVE) {
+ assert(enable_colo);
migrate_start_colo_process(s);
qemu_savevm_state_cleanup();
/*
--
2.14.3
- [Qemu-devel] [PATCH 00/11] migration: cleanup migration_thread(), Peter Xu, 2018/01/03
- [Qemu-devel] [PATCH 01/11] migration: assert colo instead of check,
Peter Xu <=
- [Qemu-devel] [PATCH 02/11] migration: qemu_savevm_state_cleanup() in cleanup, Peter Xu, 2018/01/03
- Re: [Qemu-devel] [PATCH 02/11] migration: qemu_savevm_state_cleanup() in cleanup, Juan Quintela, 2018/01/03
- Re: [Qemu-devel] [PATCH 02/11] migration: qemu_savevm_state_cleanup() in cleanup, Peter Xu, 2018/01/03
- Re: [Qemu-devel] [PATCH 02/11] migration: qemu_savevm_state_cleanup() in cleanup, Juan Quintela, 2018/01/03
- Re: [Qemu-devel] [PATCH 02/11] migration: qemu_savevm_state_cleanup() in cleanup, Peter Xu, 2018/01/03
- Re: [Qemu-devel] [PATCH 02/11] migration: qemu_savevm_state_cleanup() in cleanup, Juan Quintela, 2018/01/03
- Re: [Qemu-devel] [PATCH 02/11] migration: qemu_savevm_state_cleanup() in cleanup, Peter Xu, 2018/01/03
[Qemu-devel] [PATCH 03/11] migration: remove "enable_colo" var, Peter Xu, 2018/01/03