Re: [Qemu-devel] [PATCH v12 2/6] migration: add postcopy blocktime ctx into MigrationIncomingState

[Juan Quintela]

Eric Blake <address@hidden> wrote:
> On 10/30/2017 08:16 AM, Alexey Perevalov wrote:
>> This patch adds request to kernel space for UFFD_FEATURE_THREAD_ID,
>> in case when this feature is provided by kernel.
>
> Either 'in the case when this feature' or 'in case this feature'.
>
>> 
>> PostcopyBlocktimeContext is incapsulated inside postcopy-ram.c,
>
> s/incapsulated/encapsulated/
>
>> due to it's postcopy only feature.
>
> s/it's postcopy only/it being a postcopy-only/


>
>> Also it defines PostcopyBlocktimeContext's instance live time.
>> Information from PostcopyBlocktimeContext instance will be provided
>> much after postcopy migration end, instance of PostcopyBlocktimeContext
>> will live till QEMU exit, but part of it (vcpu_addr,
>> page_fault_vcpu_time) used only during calculation, will be released
>> when postcopy ended or failed.
>> 
>> To enable postcopy blocktime calculation on destination, need to request
>> proper capabiltiy (Patch for documentation will be at the tail of the patch
>
> s/capabiltiy/capability/

Changed for the pull request


>
>> set).
>> 
>> As an example following command enable that capability, assume QEMU was
>> started with
>> -chardev socket,id=charmonitor,path=/var/lib/migrate-vm-monitor.sock
>> option to control it
>> 
>> address@hidden "{\"execute\" : \"qmp_capabilities\"}\r\n \
>> {\"execute\": \"migrate-set-capabilities\" , \"arguments\":   {
>> \"capabilities\": [ { \"capability\": \"postcopy-blocktime\", \"state\":
>> true } ] } }" | nc -U /var/lib/migrate-vm-monitor.sock
>> 
>> Or just with HMP
>> (qemu) migrate_set_capability postcopy-blocktime on
>> 
>> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>> Signed-off-by: Alexey Perevalov <address@hidden>
>> ---