[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/11] migration: introduce vm_down_start_time
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH 06/11] migration: introduce vm_down_start_time |
Date: |
Wed, 3 Jan 2018 17:40:11 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Wed, Jan 03, 2018 at 10:10:21AM +0100, Juan Quintela wrote:
> Peter Xu <address@hidden> wrote:
> > Introduce MigrationState.vm_down_start_time to replace the local
> > variable "start_time" in migration_thread to avoid passing things around.
> >
> > Signed-off-by: Peter Xu <address@hidden>
>
> Reviewed-by: Juan Quintela <address@hidden>
>
> But I would suggest renaming the variable?
>
> Later, Juan.
>
>
> > diff --git a/migration/migration.h b/migration/migration.h
> > index 0f5df2367c..3ab5506233 100644
> > --- a/migration/migration.h
> > +++ b/migration/migration.h
> > @@ -107,6 +107,8 @@ struct MigrationState
> > int64_t mig_start_time;
> > /* Total time used by latest migration (ms) */
> > int64_t mig_total_time;
> > + /* Timestamp when VM is down (ms) to migrate the last stuff */
> > + int64_t vm_down_start_time;
>
> downtime_start?
Will do.
--
Peter Xu
- Re: [Qemu-devel] [PATCH 05/11] migration: move vm_old_running into global state, (continued)
[Qemu-devel] [PATCH 04/11] migration: split use of MigrationState.total_time, Peter Xu, 2018/01/03
[Qemu-devel] [PATCH 06/11] migration: introduce vm_down_start_time, Peter Xu, 2018/01/03
[Qemu-devel] [PATCH 08/11] migration: use switch at the end of migration, Peter Xu, 2018/01/03
[Qemu-devel] [PATCH 07/11] migration: introduce migrate_calculate_complete, Peter Xu, 2018/01/03
[Qemu-devel] [PATCH 09/11] migration: cleanup stats update into function, Peter Xu, 2018/01/03
[Qemu-devel] [PATCH 10/11] migration: major cleanup for migrate iterations, Peter Xu, 2018/01/03