[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 09/25] sdhci: Fix 64-bit ADMA2
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-devel] [PATCH v4 09/25] sdhci: Fix 64-bit ADMA2 |
Date: |
Wed, 3 Jan 2018 15:34:02 -0300 |
From: Sai Pavan Boddu <address@hidden>
The 64-bit ADMA address is not converted to the cpu endianes correctly.
This patch fixes the issue and uses a valid mask for the attribute data.
Signed-off-by: Sai Pavan Boddu <address@hidden>
[AF: Re-write commit message]
Reviewed-by: Alistair Francis <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/sd/sdhci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index 755bbbecd1..50b483cbf2 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -623,8 +623,8 @@ static void get_adma_description(SDHCIState *s, ADMADescr
*dscr)
dscr->length = le16_to_cpu(dscr->length);
dma_memory_read(&s->dma_as, entry_addr + 4,
(uint8_t *)(&dscr->addr), 8);
- dscr->attr = le64_to_cpu(dscr->attr);
- dscr->attr &= 0xfffffff8;
+ dscr->addr = le64_to_cpu(dscr->addr);
+ dscr->attr &= (uint8_t) ~0xC0;
dscr->incr = 12;
break;
}
--
2.15.1
- [Qemu-devel] [PATCH v4 00/25] SDHCI: add qtests and fix few issues, Philippe Mathieu-Daudé, 2018/01/03
- [Qemu-devel] [PATCH v4 01/25] sdhci: add a spec_version property, Philippe Mathieu-Daudé, 2018/01/03
- [Qemu-devel] [PATCH v4 02/25] sdhci: add basic Spec v1 capabilities, Philippe Mathieu-Daudé, 2018/01/03
- [Qemu-devel] [PATCH v4 03/25] sdhci: add max-block-length capability (Spec v1), Philippe Mathieu-Daudé, 2018/01/03
- [Qemu-devel] [PATCH v4 05/25] sdhci: add DMA and 64-bit capabilities (Spec v2), Philippe Mathieu-Daudé, 2018/01/03
- [Qemu-devel] [PATCH v4 06/25] sdhci: default to Spec v2, Philippe Mathieu-Daudé, 2018/01/03
- [Qemu-devel] [PATCH v4 07/25] sdhci: add a 'dma' shortcut property, Philippe Mathieu-Daudé, 2018/01/03
- [Qemu-devel] [PATCH v4 09/25] sdhci: Fix 64-bit ADMA2,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v4 10/25] hw/arm/exynos4210: implement SDHCI Spec v2, Philippe Mathieu-Daudé, 2018/01/03
- [Qemu-devel] [PATCH v4 11/25] hw/arm/xilinx_zynq: implement SDHCI Spec v2, Philippe Mathieu-Daudé, 2018/01/03
- [Qemu-devel] [PATCH v4 13/25] sdhci: check Spec v2 capabilities qtest, Philippe Mathieu-Daudé, 2018/01/03
- [Qemu-devel] [PATCH v4 12/25] sdhci: add qtest to check the SD Spec version, Philippe Mathieu-Daudé, 2018/01/03
- [Qemu-devel] [PATCH v4 15/25] sdhci: rename the hostctl1 register, Philippe Mathieu-Daudé, 2018/01/03
- [Qemu-devel] [PATCH v4 16/25] hw/arm/bcm2835_peripherals: implement SDHCI Spec v3, Philippe Mathieu-Daudé, 2018/01/03
- [Qemu-devel] [PATCH v4 17/25] hw/arm/fsl-imx6: implement SDHCI Spec v3, Philippe Mathieu-Daudé, 2018/01/03
- [Qemu-devel] [PATCH v4 18/25] hw/arm/xilinx_zynqmp: implement SDHCI Spec v3, Philippe Mathieu-Daudé, 2018/01/03
- [Qemu-devel] [PATCH v4 19/25] sdhci: check Spec v3 capabilities qtest, Philippe Mathieu-Daudé, 2018/01/03
- [Qemu-devel] [PATCH v4 20/25] sdhci: remove the deprecated 'capareg' property, Philippe Mathieu-Daudé, 2018/01/03