[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] cpu_physical_memory_sync_dirty_bitmap: Another
Re: [Qemu-devel] [PATCH] cpu_physical_memory_sync_dirty_bitmap: Another alignment fix
Wed, 03 Jan 2018 23:27:52 +0100
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
"Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
> This code has an optimised, word aligned version, and a boring
> unaligned version. My commit f70d345 fixed one alignment issue, but
> there's another.
> The optimised version operates on 'longs' dealing with (typically) 64
> pages at a time, replacing the whole long by a 0 and counting the bits.
> If the Ramblock is less than 64bits in length that long can contain bits
> representing two different RAMBlocks, but the code will update the
> bmap belinging to the 1st RAMBlock only while having updated the total
> dirty page count for both.
> This probably didn't matter prior to 6b6712ef which split the dirty
> bitmap by RAMBlock, but now they're separate RAMBlocks we end up
> with a count that doesn't match the state in the bitmaps.
> Migration showing a few dirty pages left to be sent constantly
> Seen on aarch64 and x86 with x86+ovmf
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> Reported-by: Wei Huang <address@hidden>
> Fixes: 6b6712efccd383b48a909bee0b29e079a57601ec
Reviewed-by: Juan Quintela <address@hidden>