[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 16/18] tests: fix coroutine leak in /basic/entere
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH v3 16/18] tests: fix coroutine leak in /basic/entered |
Date: |
Thu, 4 Jan 2018 17:05:21 +0100 |
The coroutine is not finished by the time the test ends, resulting in
ASAN warning:
==7005==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 312 byte(s) in 1 object(s) allocated from:
#0 0x7fd35290fa38 in __interceptor_calloc (/lib64/libasan.so.4+0xdea38)
#1 0x7fd3506c5f75 in g_malloc0 ../glib/gmem.c:124
#2 0x55994af03e47 in qemu_coroutine_new
/home/elmarco/src/qemu/util/coroutine-ucontext.c:144
#3 0x55994aefed99 in qemu_coroutine_create
/home/elmarco/src/qemu/util/qemu-coroutine.c:76
#4 0x55994ac1eb50 in verify_entered_step_1
/home/elmarco/src/qemu/tests/test-coroutine.c:80
#5 0x55994af03c75 in coroutine_trampoline
/home/elmarco/src/qemu/util/coroutine-ucontext.c:119
#6 0x7fd34ec02bef (/lib64/libc.so.6+0x50bef)
Do not yield() to let the coroutine terminate.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
---
tests/test-coroutine.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/test-coroutine.c b/tests/test-coroutine.c
index abd97c23c1..76c646107e 100644
--- a/tests/test-coroutine.c
+++ b/tests/test-coroutine.c
@@ -67,7 +67,6 @@ static void coroutine_fn verify_entered_step_2(void *opaque)
/* Once more to check it still works after yielding */
g_assert(qemu_coroutine_entered(caller));
g_assert(qemu_coroutine_entered(qemu_coroutine_self()));
- qemu_coroutine_yield();
}
static void coroutine_fn verify_entered_step_1(void *opaque)
--
2.15.1.355.g36791d7216
- [Qemu-devel] [PATCH v3 13/18] qemu-config: fix leak in query-command-line-options, (continued)
[Qemu-devel] [PATCH v3 17/18] mips: fix potential fopen(NULL,...), Marc-André Lureau, 2018/01/04
[Qemu-devel] [PATCH v3 16/18] tests: fix coroutine leak in /basic/entered,
Marc-André Lureau <=
[Qemu-devel] [PATCH v3 18/18] disas/s390: fix global-buffer-overflow, Marc-André Lureau, 2018/01/04
Re: [Qemu-devel] [PATCH v3 00/18] Various build-sys and sanitizer related fixes, no-reply, 2018/01/04
Re: [Qemu-devel] [PATCH v3 00/18] Various build-sys and sanitizer related fixes, Paolo Bonzini, 2018/01/05