[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 07/18] build-sys: add some sanitizers when --
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v3 07/18] build-sys: add some sanitizers when --enable-debug if possible |
Date: |
Thu, 4 Jan 2018 14:07:33 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/04/2018 01:05 PM, Marc-André Lureau wrote:
> Enable ASAN/UBSan by default if the compiler supports it.
>
> Typical slowdown introduced by AddressSanitizer is 2x.
> UBSan shouldn't have much impact on runtime cost.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
docker-debian-amd64 with QEMU_CONFIGURE_OPTS=--enable-debug:
Tested-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> configure | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/configure b/configure
> index 3953859314..de1477c93a 100755
> --- a/configure
> +++ b/configure
> @@ -5161,6 +5161,13 @@ if test "$gcov" = "yes" ; then
> elif test "$fortify_source" = "yes" ; then
> CFLAGS="-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 $CFLAGS"
> elif test "$debug" = "yes"; then
> + write_c_skeleton;
> + if compile_prog "-fsanitize=address" ""; then
> + CFLAGS="-fsanitize=address $CFLAGS"
> + fi
> + if compile_prog "-fsanitize=undefined" ""; then
> + CFLAGS="-fsanitize=undefined $CFLAGS"
> + fi
> if compile_prog "-Og" ""; then
> CFLAGS="-Og $CFLAGS"
> elif compile_prog "-O1" ""; then
>
- [Qemu-devel] [PATCH v3 02/18] build-sys: silence make by default or V=0, (continued)
- [Qemu-devel] [PATCH v3 02/18] build-sys: silence make by default or V=0, Marc-André Lureau, 2018/01/04
- [Qemu-devel] [PATCH v3 03/18] build-sys: add a rule to print a variable, Marc-André Lureau, 2018/01/04
- [Qemu-devel] [PATCH v3 04/18] build-sys: compile with -Og or -O1 when --enable-debug, Marc-André Lureau, 2018/01/04
- [Qemu-devel] [PATCH v3 05/18] tests/docker: add some sanitizers to fedora dockerfile, Marc-André Lureau, 2018/01/04
- [Qemu-devel] [PATCH v3 06/18] tests/docker: add test-debug, Marc-André Lureau, 2018/01/04
- [Qemu-devel] [PATCH v3 07/18] build-sys: add some sanitizers when --enable-debug if possible, Marc-André Lureau, 2018/01/04
- Re: [Qemu-devel] [PATCH v3 07/18] build-sys: add some sanitizers when --enable-debug if possible,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v3 08/18] tests: fix check-qobject leak, Marc-André Lureau, 2018/01/04
- [Qemu-devel] [PATCH v3 09/18] vl: fix direct firmware directories leak, Marc-André Lureau, 2018/01/04
- [Qemu-devel] [PATCH v3 10/18] readline: add a free function, Marc-André Lureau, 2018/01/04
- [Qemu-devel] [PATCH v3 11/18] tests: fix migration-test leak, Marc-André Lureau, 2018/01/04
- [Qemu-devel] [PATCH v3 12/18] crypto: fix stack-buffer-overflow error, Marc-André Lureau, 2018/01/04
- [Qemu-devel] [PATCH v3 13/18] qemu-config: fix leak in query-command-line-options, Marc-André Lureau, 2018/01/04
- [Qemu-devel] [PATCH v3 14/18] tests: fix qmp-test leak, Marc-André Lureau, 2018/01/04