[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 00/20] add byte-based block_status driver cal
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v7 00/20] add byte-based block_status driver callbacks |
Date: |
Mon, 8 Jan 2018 11:21:44 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Mon, 01/08 10:56, Fam Zheng wrote:
> On Sat, 01/06 22:03, address@hidden wrote:
> > /var/tmp/patchew-tester-tmp-zu_flv2_/src/block/iscsi.c: In function
> > ‘iscsi_co_block_status’:
> > /var/tmp/patchew-tester-tmp-zu_flv2_/src/block/iscsi.c:755:14: error:
> > ‘iTask.task’ may be used uninitialized in this function
> > [-Werror=maybe-uninitialized]
> > if (iTask.task != NULL) {
> > ~~~~~^~~~~
> > cc1: all warnings being treated as errors
> > make: *** [/var/tmp/patchew-tester-tmp-zu_flv2_/src/rules.mak:66:
> > block/iscsi.o] Error 1
> > make: *** Waiting for unfinished jobs....
> > === OUTPUT END ===
> >
> > Test command exited with code: 2
>
> Seems introduced by e38bc23454ef763deb4405ebdee6a1081aa00bc8. I think the easy
> fix is to initialize iTask.task to NULL.
I've posted a fix for this:
https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg01132.html
Fam
- [Qemu-devel] [PATCH v7 14/20] sheepdog: Switch to .bdrv_co_block_status(), (continued)
- [Qemu-devel] [PATCH v7 14/20] sheepdog: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-devel] [PATCH v7 15/20] vdi: Avoid bitrot of debugging code, Eric Blake, 2018/01/05
- [Qemu-devel] [PATCH v7 17/20] vmdk: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-devel] [PATCH v7 16/20] vdi: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-devel] [PATCH v7 18/20] vpc: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-devel] [PATCH v7 19/20] vvfat: Switch to .bdrv_co_block_status(), Eric Blake, 2018/01/05
- [Qemu-devel] [PATCH v7 20/20] block: Drop unused .bdrv_co_get_block_status(), Eric Blake, 2018/01/05
- Re: [Qemu-devel] [PATCH v7 00/20] add byte-based block_status driver callbacks, no-reply, 2018/01/07
- Re: [Qemu-devel] [PATCH v7 00/20] add byte-based block_status driver callbacks, Eric Blake, 2018/01/29