Re: [Qemu-devel] [PATCH v2] target/arm: Fix stlxp for aarch64_be

[Peter Maydell]

On 30 December 2017 at 22:56, Michael Weiser <address@hidden> wrote:
> ldxp loads two consecutive doublewords from memory regardless of CPU
> endianness. On store, stlxp currently assumes to work with a 128bit
> value and consequently switches order in big-endian mode. With this
> change it packs the doublewords in reverse order in anticipation of the
> 128bit big-endian store operation interposing them so they end up in
> memory in the right order. This makes it work for both MTTCG and !MTTCG.
> It effectively implements the ARM ARM STLXP operation pseudo-code:
>
> data = if BigEndian() then el1:el2 else el2:el1;
>
> With this change an aarch64_be Linux 4.14.4 kernel succeeds to boot up
> in system emulation mode.
>
> Signed-off-by: Michael Weiser <address@hidden>

Thanks, applied to target-arm.next (with the typo rth pointed out
fixed).

-- PMM