[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 13/14] 9pfs: deprecate handle backend
From: |
Greg Kurz |
Subject: |
[Qemu-devel] [PULL 13/14] 9pfs: deprecate handle backend |
Date: |
Mon, 8 Jan 2018 15:28:30 +0100 |
This backend raise some concerns:
- doesn't support symlinks
- fails +100 tests in the PJD POSIX file system test suite [1]
- requires the QEMU process to run with the CAP_DAC_READ_SEARCH
capability, which isn't recommended for security reasons
This backend should not be used and wil be removed. The 'local'
backend is the recommended alternative.
[1] https://www.tuxera.com/community/posix-test-suite/
Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Aneesh Kumar K.V <address@hidden>
---
hw/9pfs/9p-handle.c | 2 ++
qemu-doc.texi | 8 ++++++++
2 files changed, 10 insertions(+)
diff --git a/hw/9pfs/9p-handle.c b/hw/9pfs/9p-handle.c
index c5adfe6f3a96..c1681d3c8ac0 100644
--- a/hw/9pfs/9p-handle.c
+++ b/hw/9pfs/9p-handle.c
@@ -657,6 +657,8 @@ static int handle_parse_opts(QemuOpts *opts, FsDriverEntry
*fse, Error **errp)
const char *sec_model = qemu_opt_get(opts, "security_model");
const char *path = qemu_opt_get(opts, "path");
+ warn_report("handle backend is deprecated");
+
if (sec_model) {
error_report("Invalid argument security_model specified with handle
fsdriver");
return -1;
diff --git a/qemu-doc.texi b/qemu-doc.texi
index ae90f7199eca..454a8313d0de 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@ -2724,6 +2724,14 @@ default channel subsystem image for guests that do not
support multiple
channel subsystems, all devices can be put into the default channel
subsystem image.
address@hidden -fsdev handle (since 2.12.0)
+
+The ``handle'' fsdev backend does not support symlinks and causes the 9p
+filesystem in the guest to fail a fair amount of tests from the PJD POSIX
+filesystem test suite. Also it requires the CAP_DAC_READ_SEARCH capability,
+which is not the recommended way to run QEMU. This backend should not be
+used and it will be removed with no replacement.
+
@section qemu-img command line arguments
@subsection convert -s (since 2.0.0)
--
2.13.6
- [Qemu-devel] [PULL 00/14] 9p patches for 2.12 20180108, Greg Kurz, 2018/01/08
- [Qemu-devel] [PULL 10/14] tests: virtio-9p: set DRIVER_OK before using the device, Greg Kurz, 2018/01/08
- [Qemu-devel] [PULL 05/14] 9pfs: handle: fix type definition, Greg Kurz, 2018/01/08
- [Qemu-devel] [PULL 04/14] 9pfs: fix some type definitions, Greg Kurz, 2018/01/08
- [Qemu-devel] [PULL 07/14] 9pfs: fix error path in pdu_submit(), Greg Kurz, 2018/01/08
- [Qemu-devel] [PULL 08/14] 9pfs: make pdu_marshal() and pdu_unmarshal() static functions, Greg Kurz, 2018/01/08
- [Qemu-devel] [PULL 02/14] 9pfs: fix XattrOperations typedef, Greg Kurz, 2018/01/08
- [Qemu-devel] [PULL 13/14] 9pfs: deprecate handle backend,
Greg Kurz <=
- [Qemu-devel] [PULL 03/14] fsdev: fix some type definitions, Greg Kurz, 2018/01/08
- [Qemu-devel] [PULL 12/14] fsdev: improve error handling of backend init, Greg Kurz, 2018/01/08
- [Qemu-devel] [PULL 09/14] tests: virtio-9p: fix ISR dependence, Greg Kurz, 2018/01/08
- [Qemu-devel] [PULL 06/14] 9pfs: fix type in *_parse_opts declarations, Greg Kurz, 2018/01/08
- [Qemu-devel] [PULL 01/14] virtio-9p: move unrealize/realize after virtio_9p_transport definition, Greg Kurz, 2018/01/08
- [Qemu-devel] [PULL 11/14] fsdev: improve error handling of backend opts parsing, Greg Kurz, 2018/01/08
- [Qemu-devel] [PULL 14/14] MAINTAINERS: Drop Aneesh as 9pfs maintainer, Greg Kurz, 2018/01/08
- Re: [Qemu-devel] [PULL 00/14] 9p patches for 2.12 20180108, Peter Maydell, 2018/01/09