Re: [Qemu-devel] [PATCH 00/16] target/xtensa updates

[Peter Maydell]

On 27 December 2017 at 17:46, Max Filippov <address@hidden> wrote:
> Hi Peter,
>
> please pull the following batch of updates for the target/xtensa.
>
> The following changes since commit 0a0dc59d27527b78a195c2d838d28b7b49e5a639:
>
>   Update version for v2.11.0 release (2017-12-13 14:31:09 +0000)
>
> are available in the git repository at:
>
>   git://github.com/OSLL/qemu-xtensa.git tags/20171227-xtensa
>
> for you to fetch changes up to d462b6b6b79f092327927b3fb3ac20505c90a706:
>
>   target/xtensa: implement disassembler (2017-12-18 21:26:20 -0800)
>
> ----------------------------------------------------------------
> target/xtensa updates:
>
> - add libisa to the xtensa target;
> - change xtensa instruction translator to use it;
> - switch existing xtensa cores to use it;
> - add support for a number of instructions: salt/saltu, const16,
>   GPIO32 group, debug mode and MMU-related;
> - add disassembler for Xtensa.

Hi; I'm afraid this doesn't build on clang:

/home/petmay01/linaro/qemu-for-merges/target/xtensa/translate.c:261:20:
error: unused function 'option_bits_enabled'
[-Werror,-Wunused-function]
static inline bool option_bits_enabled(DisasContext *dc, uint64_t opt)
                   ^
1 error generated.

Probably an easy fix; clang is stricter than gcc about
not liking unused static inline functions in .c files.

thanks
-- PMM