[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison oper
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator |
|
Date: |
Mon, 8 Jan 2018 11:15:45 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 01/08/2018 11:10 AM, Peter Maydell wrote:
> In commit c97d6d2cdf97ed we accidentally added code to configure
> that uses '==' for string equality testing. This is a bashism --
> the portable way to write this is '='.
>
> This fixes the "Unexpected operator error" complaint produced
> if the system /bin/sh is dash.
>
> Fixes: c97d6d2cdf97ed
> Reported-by: Philippe Mathieu-Daudé <address@hidden>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> As an aside, it's annoying that this doesn't make configure fail;
> otherwise it wouldn't have got through my build tests.
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature