[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison oper
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator |
|
Date: |
Mon, 8 Jan 2018 21:01:15 +0000 |
On 8 January 2018 at 17:16, Philippe Mathieu-Daudé <address@hidden> wrote:
> On 01/08/2018 02:10 PM, Peter Maydell wrote:
>> In commit c97d6d2cdf97ed we accidentally added code to configure
>> that uses '==' for string equality testing. This is a bashism --
>> the portable way to write this is '='.
>>
>> This fixes the "Unexpected operator error" complaint produced
>> if the system /bin/sh is dash.
>
> Thanks :)
>
>>
>> Fixes: c97d6d2cdf97ed
>> Reported-by: Philippe Mathieu-Daudé <address@hidden>
>> Signed-off-by: Peter Maydell <address@hidden>
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-by: Philippe Mathieu-Daudé <address@hidden>
Applied to master, thanks.
-- PMM