[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 12/12] slirp: use HOST_SUPPORTS_UNALIGNED_AC
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH 12/12] slirp: use HOST_SUPPORTS_UNALIGNED_ACCESS |
|
Date: |
Tue, 9 Jan 2018 10:52:18 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 08/01/2018 18:29, Philippe Mathieu-Daudé wrote:
> Access struct in6_addr with 'void *', then cast to 'u8 *' to avoid alignment
> issues.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> ugly...
>
> slirp/ip6.h | 58 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 58 insertions(+)
What is the bug exactly? If a->s6_addr can be unaligned, this should be
in the commit message.
In any case, there is no need to keep the versions that use struct
in6_addr, you can use the void* version unconditionally.
Paolo
- Re: [Qemu-devel] [PATCH 08/12] slirp: removed unused code, (continued)
- [Qemu-devel] [PATCH 09/12] slirp: add in6_dhcp_multicast(), Philippe Mathieu-Daudé, 2018/01/08
- [Qemu-devel] [PATCH 10/12] configure: disable unaligned access warning on x86 arch, Philippe Mathieu-Daudé, 2018/01/08
- [Qemu-devel] [PATCH 11/12] configure: add HOST_SUPPORTS_UNALIGNED_ACCESS, Philippe Mathieu-Daudé, 2018/01/08
- [Qemu-devel] [RFC PATCH 12/12] slirp: use HOST_SUPPORTS_UNALIGNED_ACCESS, Philippe Mathieu-Daudé, 2018/01/08
- Re: [Qemu-devel] [PATCH 00/12] add HOST_SUPPORTS_UNALIGNED_ACCESS, reduce slirp warnings, no-reply, 2018/01/08