[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-arm] [PATCH 2/4] hw/sd/milkymist-memcard: Reset S
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [Qemu-arm] [PATCH 2/4] hw/sd/milkymist-memcard: Reset SD card on controller reset |
Date: |
Tue, 9 Jan 2018 13:08:41 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
Hi Peter,
On 01/09/2018 11:01 AM, Peter Maydell wrote:
> Since pl181 is still using the legacy SD card API, the SD
pl181 -> milkymist-memcard ;)
> card created by sd_init() is not plugged into any bus. This
> means that the controller has to reset it manually.
>
> Failing to do this mostly didn't affect the guest since the
> guest typically does a programmed SD card reset as part of
> its SD controller driver initialization, but meant that
> migration failed because it's only in sd_reset() that we
> set up the wpgrps_size field.
>
> Cc: address@hidden
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> hw/sd/milkymist-memcard.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c
> index 4008c81..341da88 100644
> --- a/hw/sd/milkymist-memcard.c
> +++ b/hw/sd/milkymist-memcard.c
> @@ -248,6 +248,10 @@ static void milkymist_memcard_reset(DeviceState *d)
> for (i = 0; i < R_MAX; i++) {
> s->regs[i] = 0;
> }
> + /* Since we're still using the legacy SD API the card is not plugged
> + * into any bus, and we must reset it manually.
> + */
> + device_reset(DEVICE(s->card));
> }
>
> static int milkymist_memcard_init(SysBusDevice *dev)
>
signature.asc
Description: OpenPGP digital signature