[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/6] qapi: add name parameter to nbd-server-a
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/6] qapi: add name parameter to nbd-server-add |
Date: |
Tue, 9 Jan 2018 13:05:10 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 12/07/2017 09:50 AM, Vladimir Sementsov-Ogievskiy wrote:
> Allow user to specify name for new export, to not reuse internal
> node name and to not show it to clients.
>
> This also allows creating several exports per device.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> qapi/block.json | 9 +++++++--
> blockdev-nbd.c | 14 +++++++++-----
> hmp.c | 5 +++--
> 3 files changed, 19 insertions(+), 9 deletions(-)
>
> diff --git a/qapi/block.json b/qapi/block.json
> index f093fa3f27..503d4b287b 100644
> --- a/qapi/block.json
> +++ b/qapi/block.json
> @@ -213,14 +213,19 @@
> #
> # @device: The device name or node name of the node to be exported
> #
> +# @name: Export name. If unspecified @device parameter used as export name.
s/unspecified/unspecified, the/
s/used as/is used as the/
Will tweak as part of applying to my NBD queue.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 2/6] qapi: add name parameter to nbd-server-add,
Eric Blake <=