[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v6 06/27] monitor: move the cur_mon hack deeper fo
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC v6 06/27] monitor: move the cur_mon hack deeper for QMP |
Date: |
Tue, 9 Jan 2018 16:57:21 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 12/19/2017 02:45 AM, Peter Xu wrote:
> In monitor_qmp_read(), we have the hack to temporarily replace the
> cur_mon pointer. Now we move this hack deeper inside the QMP dispatcher
> routine since the Monitor pointer can be actually obtained using
> container_of() upon the parser object, just like most of the other JSON
> parser users do.
>
> This does not make much sense as a single patch. However, this will be
> a big step for the next patch, when the QMP dispatcher routine will be
> split from the QMP parser.
>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> monitor.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [RFC v6 06/27] monitor: move the cur_mon hack deeper for QMP,
Eric Blake <=