Re: [Qemu-devel] [qemu-s390x] [PATCH 1/6] accel/tcg: add size paremeter in tlb_fill()

[David Hildenbrand]

On 09.01.2018 00:10, Laurent Vivier wrote:
> The MC68040 MMU provides the size of the access that
> triggers the page fault.
> 
> This size is set in the Special Status Word which
> is written in the stack frame of the access fault
> exception.
> 
> So we need the size in m68k_cpu_unassigned_access() and
> m68k_cpu_handle_mmu_fault().
> 
> To be able to do that, this patch modifies the prototype of
> handle_mmu_fault handler, tlb_fill() and probe_write().
> do_unassigned_access() already includes a size parameter.
> 
> This patch also updates handle_mmu_fault handlers and
> tlb_fill() of all targets (only parameter, no code change).
> 

There are a couple of places where you use "1" (when no other size is
available). e.g. in get_page_addr_code().

Wonder if that's the right thing to do - are there any architectures
that e.g. always fetch at least 2 bytes in these conditions?

Apart from that, looks sane to me (for other architectures :) )

-- 

Thanks,

David / dhildenb