[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState |
Date: |
Thu, 11 Jan 2018 10:20:09 +0000 |
On 11 January 2018 at 10:15, Paolo Bonzini <address@hidden> wrote:
> RAM contents are memcpy'd blindly during loadvm. I think that's what
> requires a tb_flush.
Ah, that makes sense. Could we have a comment documenting the
rationale, please? Something like:
/* vmload has just updated the content of RAM, bypassing the
* usual mechanisms that ensure we flush TBs for writes to
* memory we've translated code from. So we must flush all TBs,
* which will now be stale.
*/
thanks
-- PMM