[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v3 03/30] This patch adds a condition before
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH v3 03/30] This patch adds a condition before overwriting exception_index fields. |
Date: |
Thu, 11 Jan 2018 13:29:34 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 11/01/2018 09:25, Pavel Dovgalyuk wrote:
> It is needed when exception_index is already set to some meaningful value.
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> accel/tcg/cpu-exec.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
> index 280200f..9cc6972 100644
> --- a/accel/tcg/cpu-exec.c
> +++ b/accel/tcg/cpu-exec.c
> @@ -585,6 +585,7 @@ static inline bool cpu_handle_interrupt(CPUState *cpu,
> else {
> if (cc->cpu_exec_interrupt(cpu, interrupt_request)) {
> replay_interrupt();
> + cpu->exception_index = -1;
> *last_tb = NULL;
> }
> /* The target hook may have updated the 'cpu->interrupt_request';
> @@ -606,7 +607,9 @@ static inline bool cpu_handle_interrupt(CPUState *cpu,
> if (unlikely(atomic_read(&cpu->exit_request)
> || (use_icount && cpu->icount_decr.u16.low + cpu->icount_extra ==
> 0))) {
> atomic_set(&cpu->exit_request, 0);
> - cpu->exception_index = EXCP_INTERRUPT;
> + if (cpu->exception_index == -1) {
> + cpu->exception_index = EXCP_INTERRUPT;
> + }
> return true;
> }
>
>
Where does my S-o-b come from? :)
Paolo
- [Qemu-devel] [RFC PATCH v3 00/30] replay additions, Pavel Dovgalyuk, 2018/01/11
- [Qemu-devel] [RFC PATCH v3 01/30] hpet: recover timer offset correctly, Pavel Dovgalyuk, 2018/01/11
- [Qemu-devel] [RFC PATCH v3 02/30] cpu: flush TB cache when loading VMState, Pavel Dovgalyuk, 2018/01/11
- [Qemu-devel] [RFC PATCH v3 03/30] This patch adds a condition before overwriting exception_index fields., Pavel Dovgalyuk, 2018/01/11
- Re: [Qemu-devel] [RFC PATCH v3 03/30] This patch adds a condition before overwriting exception_index fields.,
Paolo Bonzini <=
- [Qemu-devel] [RFC PATCH v3 04/30] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2018/01/11
- [Qemu-devel] [RFC PATCH v3 05/30] blkreplay: create temporary overlay for underlaying devices, Pavel Dovgalyuk, 2018/01/11
- [Qemu-devel] [RFC PATCH v3 06/30] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2018/01/11
- [Qemu-devel] [RFC PATCH v3 07/30] replay: fix processing async events, Pavel Dovgalyuk, 2018/01/11
- [Qemu-devel] [RFC PATCH v3 08/30] replay: fixed replay_enable_events, Pavel Dovgalyuk, 2018/01/11
- [Qemu-devel] [RFC PATCH v3 09/30] replay: fix save/load vm for non-empty queue, Pavel Dovgalyuk, 2018/01/11
- [Qemu-devel] [RFC PATCH v3 10/30] replay: added replay log format description, Pavel Dovgalyuk, 2018/01/11
- [Qemu-devel] [RFC PATCH v3 11/30] replay: make safe vmstop at record/replay, Pavel Dovgalyuk, 2018/01/11
- [Qemu-devel] [RFC PATCH v3 12/30] replay: save prior value of the host clock, Pavel Dovgalyuk, 2018/01/11