Re: [Qemu-devel] [PATCH v4 3/9] block: Add VFIO based NVMe driver

[Fam Zheng]

On Wed, 01/10 18:33, Stefan Hajnoczi wrote:
> > +    ret = event_notifier_init(&s->irq_notifier, 0);
> > +    if (ret) {
> > +        error_setg(errp, "Failed to init event notifier");
> > +        return ret;
> 
> dma_map_lock should be destroyed.

CoMutexes are initialized by memset so I don't think destroying is necessary:

    void qemu_co_mutex_init(CoMutex *mutex)
    {
        memset(mutex, 0, sizeof(*mutex));
    }

(I agree to and will fix other issues you pointed out. Thanks for the quick
review!)

Fam