Re: [Qemu-devel] [RFC PATCH v3 00/30] replay additions

[Paolo Bonzini]

On 11/01/2018 13:56, Paolo Bonzini wrote:
> On 11/01/2018 09:24, Pavel Dovgalyuk wrote:
>> Accidentally sent draft version of patches to the mailing list.
>> Please consider this one as the correct one.
>>
>> This set of patches includex fixes from Alex Bennée for fixing
>> BQL and replay locks after inventing the MTTCG. It also includes some
>> additional replay patches that makes this set of fixes working.
>> It is also fixes some vmstate creation (and loading) issues
>> in record/replay modes:
>>  - VM start/stop fixes in replay mode
>>  - overlay creation for blkreplay filter
>>  - fixes for vmstate save/load in record/replay mode
>>  - fixes for host clock vmstate
>>  - fixes for icount timers vmstate
>>
>> There is also a set of helper scripts written by Alex Bennée
>> for debugging the record/replay code.
> 
> For now, I'm applying patches 13, 24-26 and 28.

Which don't compile on Windows.

This is the second series I've applied from you this morning that
doesn't compile at all.  Please be more careful.

Paolo

> 
> Paolo
> 
>>
>> v3 changes:
>>  - removed upstreamed patches
>>  - fixed bug with recursive checkpoints
>>  - fixed bug with icount warp checkpoint
>>
>> v2 changes:
>>  - updated lock/unlock logic (as suggested by Paolo Bonzini)
>>  - updated cpu execution loop to avoid races in setting/resetting exit 
>> request (as suggested by Paolo Bonzini)
>>  - minor changes
>>
>> ---
>>
>> Alex Bennée (12):
>>       target/arm/arm-powertctl: drop BQL assertions
>>       cpus: push BQL lock to qemu_*_wait_io_event
>>       cpus: only take BQL for sleeping threads
>>       replay/replay.c: bump REPLAY_VERSION again
>>       replay/replay-internal.c: track holding of replay_lock
>>       replay: make locking visible outside replay code
>>       replay: push replay_mutex_lock up the call tree
>>       scripts/qemu-gdb: add simple tcg lock status helper
>>       util/qemu-thread-*: add qemu_lock, locked and unlock trace events
>>       scripts/analyse-locks-simpletrace.py: script to analyse lock times
>>       scripts/replay-dump.py: replay log dumper
>>       scripts/qemu-gdb/timers.py: new helper to dump timer state
>>
>> Pavel Dovgalyuk (18):
>>       hpet: recover timer offset correctly
>>       cpu: flush TB cache when loading VMState
>>       This patch adds a condition before overwriting exception_index fields.
>>       block: implement bdrv_snapshot_goto for blkreplay
>>       blkreplay: create temporary overlay for underlaying devices
>>       replay: disable default snapshot for record/replay
>>       replay: fix processing async events
>>       replay: fixed replay_enable_events
>>       replay: fix save/load vm for non-empty queue
>>       replay: added replay log format description
>>       replay: make safe vmstop at record/replay
>>       replay: save prior value of the host clock
>>       icount: fixed saving/restoring of icount warp timers
>>       replay: don't destroy mutex at exit
>>       replay: check return values of fwrite
>>       replay: avoid recursive call of checkpoints
>>       replay: improve replay performance
>>       replay: don't process async events when warping the clock
>>
>>
>>  accel/kvm/kvm-all.c                  |    4 
>>  accel/tcg/cpu-exec.c                 |    5 -
>>  block/blkreplay.c                    |   73 ++++++++
>>  cpus-common.c                        |   13 +
>>  cpus.c                               |  184 +++++++++++++++-----
>>  docs/replay.txt                      |   91 ++++++++++
>>  exec.c                               |    1 
>>  hw/timer/hpet.c                      |   30 +++
>>  include/hw/compat.h                  |    6 +
>>  include/qemu/thread.h                |   19 ++
>>  include/qemu/timer.h                 |   14 ++
>>  include/sysemu/replay.h              |   22 ++
>>  migration/savevm.c                   |   13 +
>>  replay/replay-char.c                 |   21 +-
>>  replay/replay-events.c               |   30 +--
>>  replay/replay-internal.c             |   48 +++++
>>  replay/replay-internal.h             |    9 +
>>  replay/replay-snapshot.c             |    9 +
>>  replay/replay-time.c                 |   10 +
>>  replay/replay.c                      |   75 ++++++--
>>  scripts/analyse-locks-simpletrace.py |   99 +++++++++++
>>  scripts/qemu-gdb.py                  |    4 
>>  scripts/qemugdb/tcg.py               |   46 +++++
>>  scripts/qemugdb/timers.py            |   54 ++++++
>>  scripts/replay-dump.py               |  308 
>> ++++++++++++++++++++++++++++++++++
>>  stubs/replay.c                       |   16 ++
>>  target/arm/arm-powerctl.c            |    8 -
>>  target/i386/hax-all.c                |    2 
>>  util/main-loop.c                     |   17 +-
>>  util/qemu-thread-posix.c             |   21 +-
>>  util/qemu-timer.c                    |   12 +
>>  util/trace-events                    |    7 -
>>  vl.c                                 |   12 +
>>  33 files changed, 1112 insertions(+), 171 deletions(-)
>>  create mode 100755 scripts/analyse-locks-simpletrace.py
>>  create mode 100644 scripts/qemugdb/tcg.py
>>  create mode 100644 scripts/qemugdb/timers.py
>>  create mode 100755 scripts/replay-dump.py
>>
> 
>