Re: [Qemu-devel] [PATCH] docker: change Fedora base image to fedora:27

[Paolo Bonzini]

On 12/01/2018 12:28, Philippe Mathieu-Daudé wrote:
> Hi Paolo,
> 
> On 01/12/2018 08:11 AM, Paolo Bonzini wrote:
>> Using "fedora:latest" makes behavior different depending on when you
>> actually pulled the image from the docker repository.  In my case,
>> the supposedly "latest" image was a Fedora 25 download from 8 months
>> ago, and the new "test-debug" test was failing.
>>
>> Use "27" to improve reproducibility and make it clear when the image
>> is obsolete.
>>
>> Cc: Fam Zheng <address@hidden>
>> Cc: Marc-André Lureau <address@hidden>
> 
> I wonder what script you are using, and if the R: tag in MAINTAINERS is
> that useful, since I saw few docker patches I'm interestd in but I was
> not CC'd:

No, it's my fault

> $ ./scripts/get_maintainer.pl -f tests/docker/dockerfiles/fedora.docker
> "Alex Bennée" <address@hidden> (maintainer:Build and test au...)
> Fam Zheng <address@hidden> (maintainer:Build and test au...)
> "Philippe Mathieu-Daudé" <address@hidden> (reviewer:Build and test au...)
> 
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>>  tests/docker/dockerfiles/fedora.docker | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/docker/dockerfiles/fedora.docker 
>> b/tests/docker/dockerfiles/fedora.docker
>> index 32de731..714adad 100644
>> --- a/tests/docker/dockerfiles/fedora.docker
>> +++ b/tests/docker/dockerfiles/fedora.docker
>> @@ -1,4 +1,4 @@
>> -FROM fedora:latest
>> +FROM fedora:27
> 
> I'd rather use the deprecation approach like we use for Debian,
> see tests/docker/dockerfiles/debian.docker.
> 
> That said, you remind me of a series doing the same for Ubuntu I forgot
> to send, if you want I can add fedora25 and fedora27 before sending.

That's fine by me (but use "fedora" instead of fedora25).

Paolo