[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v3 29/30] replay: improve replay performance
From: |
Pavel Dovgalyuk |
Subject: |
Re: [Qemu-devel] [RFC PATCH v3 29/30] replay: improve replay performance |
Date: |
Fri, 12 Jan 2018 15:41:53 +0300 |
> From: Paolo Bonzini [mailto:address@hidden
> On 12/01/2018 07:13, Pavel Dovgalyuk wrote:
> >> From: Paolo Bonzini [mailto:address@hidden
> >> On 11/01/2018 14:12, Pavel Dovgalyuk wrote:
> >>>> From: Paolo Bonzini [mailto:address@hidden On Behalf Of Paolo Bonzini
> >>>> On 11/01/2018 09:27, Pavel Dovgalyuk wrote:
> >>>>> + } else {
> >>>>> + qemu_notify_event();
> >>>>> + }
> >>>>
> >>>> Before this patch, what would do the qemu_notify_event?
> >>>
> >>> We tried using qemu_notify_event to wake up the iothread and speedup the
> >>> replay,
> >>> when there is no work for vcpu thread to do.
> >>
> >> But why doesn't the iothread wake up on its own?
> >
> > It will wake up by timeout. But with this change this happens sooner and
> > replay goes faster.
>
> If you want replays to ignore timeouts, that should be done by ensuring
> that qemu-timer.c passes a zero timeout to main-loop.c. (It probably
> should be optional, too, maybe via -icount sleep).
Making it optional is a good one.
I'll exclude this patch from the series for working on it later.
Pavel Dovgalyuk
- [Qemu-devel] [RFC PATCH v3 25/30] util/qemu-thread-*: add qemu_lock, locked and unlock trace events, (continued)
- [Qemu-devel] [RFC PATCH v3 25/30] util/qemu-thread-*: add qemu_lock, locked and unlock trace events, Pavel Dovgalyuk, 2018/01/11
- [Qemu-devel] [RFC PATCH v3 26/30] scripts/analyse-locks-simpletrace.py: script to analyse lock times, Pavel Dovgalyuk, 2018/01/11
- [Qemu-devel] [RFC PATCH v3 27/30] scripts/replay-dump.py: replay log dumper, Pavel Dovgalyuk, 2018/01/11
- [Qemu-devel] [RFC PATCH v3 28/30] scripts/qemu-gdb/timers.py: new helper to dump timer state, Pavel Dovgalyuk, 2018/01/11
- [Qemu-devel] [RFC PATCH v3 29/30] replay: improve replay performance, Pavel Dovgalyuk, 2018/01/11
[Qemu-devel] [RFC PATCH v3 30/30] replay: don't process async events when warping the clock, Pavel Dovgalyuk, 2018/01/11
Re: [Qemu-devel] [RFC PATCH v3 00/30] replay additions, no-reply, 2018/01/11
Re: [Qemu-devel] [RFC PATCH v3 00/30] replay additions, no-reply, 2018/01/11
Re: [Qemu-devel] [RFC PATCH v3 00/30] replay additions, Paolo Bonzini, 2018/01/11