[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/20] include/fpu/softfloat: implement float
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/20] include/fpu/softfloat: implement float16_abs helper |
Date: |
Fri, 12 Jan 2018 13:42:45 +0000 |
On 9 January 2018 at 12:22, Alex Bennée <address@hidden> wrote:
> This will be required when expanding the MINMAX() macro for 16
> bit/half-precision operations.
>
> Signed-off-by: Alex Bennée <address@hidden>
> Reviewed-by: Richard Henderson <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> include/fpu/softfloat.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h
> index 52af1412de..cfc615008d 100644
> --- a/include/fpu/softfloat.h
> +++ b/include/fpu/softfloat.h
> @@ -347,6 +347,13 @@ static inline int float16_is_zero_or_denormal(float16 a)
> return (float16_val(a) & 0x7c00) == 0;
> }
>
> +static inline float16 float16_abs(float16 a)
> +{
> + /* Note that abs does *not* handle NaN specially, nor does
> + * it flush denormal inputs to zero.
> + */
> + return make_float16(float16_val(a) & 0x7fff);
> +}
>
> /*----------------------------------------------------------------------------
> | The pattern for a default generated half-precision NaN.
>
> *----------------------------------------------------------------------------*/
> --
> 2.15.1
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES, (continued)
- Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES, Laurent Vivier, 2018/01/09
- Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES, Aurelien Jarno, 2018/01/09
- Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES, Peter Maydell, 2018/01/09
- Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES, Laurent Vivier, 2018/01/09
- Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES, Peter Maydell, 2018/01/09
- Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES, Richard Henderson, 2018/01/09
- Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES, Alex Bennée, 2018/01/09
[Qemu-devel] [PATCH v2 05/20] include/fpu/softfloat: implement float16_set_sign helper, Alex Bennée, 2018/01/09
[Qemu-devel] [PATCH v2 03/20] include/fpu/softfloat: implement float16_abs helper, Alex Bennée, 2018/01/09
- Re: [Qemu-devel] [PATCH v2 03/20] include/fpu/softfloat: implement float16_abs helper,
Peter Maydell <=
[Qemu-devel] [PATCH v2 06/20] include/fpu/softfloat: add some float16 constants, Alex Bennée, 2018/01/09
[Qemu-devel] [PATCH v2 04/20] include/fpu/softfloat: implement float16_chs helper, Alex Bennée, 2018/01/09
[Qemu-devel] [PATCH v2 01/20] fpu/softfloat: implement float16_squash_input_denormal, Alex Bennée, 2018/01/09
[Qemu-devel] [PATCH v2 08/20] fpu/softfloat: improve comments on ARM NaN propagation, Alex Bennée, 2018/01/09