[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/6] iotests: implement QemuIoInteractive cla
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/6] iotests: implement QemuIoInteractive class |
Date: |
Fri, 12 Jan 2018 10:48:38 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/12/2018 05:56 AM, Vladimir Sementsov-Ogievskiy wrote:
>> My python is not strong; it looks good overall, although I have a few
>> questions that may warrant a v3 before I give R-b.
>>
>>> +class QemuIoInteractive:
>>> + def __init__(self, *args):
>>> + self.args = qemu_io_args + list(args)
>>> + self._p = subprocess.Popen(self.args, stdin=subprocess.PIPE,
>>> + stdout=subprocess.PIPE,
>>> + stderr=subprocess.STDOUT)
>> Why STDOUT instead of STDERR? Is the redirection intentional?
>
> this special flag means: "send subprocess stderr to the same place as
> stdout", so,
> I'll have both stdout and stderr in one .PIPE. I don't print these
> outputs, but return
> them to the user.
Okay, makes sense (my python inexperience is showing ;)
I'd welcome a review from anyone else, but since the resulting test
passes, I'm not opposed to taking the patch as-is. If it goes through
my NBD queue, it will get my S-o-b (because I'll have to touch it); but
if it goes through anyone else's queue, that maintainer can add this
(weaker than R-b, but at least says I'm okay with it):
Acked-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature