Re: [Qemu-devel] [PATCH 6/8] vl.c: disallow command line fw cfg without opt/

[Marc-André Lureau]

Hi

On Thu, Dec 7, 2017 at 10:30 PM,  <address@hidden> wrote:
> From: "Michael S. Tsirkin" <address@hidden>
>
> Allowing arbitary file names on command line is setting us up for
> failure: future guests will look for a specific QEMU-specified name and
> will get confused finding a user file there.
>

Why is this part of a IPMI series?
There was a lengthy discussion on this patch earlier, could you
summarize the conclusion?

thanks

> Signed-off-by: Michael S. Tsirkin <address@hidden>
> [Change "warning" to "error" in the error report.]
> Signed-off-by: Corey Minyard <address@hidden>
> ---
>  vl.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 1ad1c04..fae9300 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2400,8 +2400,9 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts, 
> Error **errp)
>          return -1;
>      }
>      if (strncmp(name, "opt/", 4) != 0) {
> -        warn_report("externally provided fw_cfg item names "
> -                    "should be prefixed with \"opt/\"");
> +        error_report("error: externally provided fw_cfg item names "
> +                     "should be prefixed with \"opt/\"");
> +        return -1;
>      }
>      if (nonempty_str(str)) {
>          size = strlen(str); /* NUL terminator NOT included in fw_cfg blob */
> --
> 2.7.4
>
>



-- 
Marc-André Lureau