qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 1/3] tpm: Implement virtual memory device fo


From: Stefan Berger
Subject: Re: [Qemu-devel] [RFC PATCH 1/3] tpm: Implement virtual memory device for TPM PPI
Date: Fri, 12 Jan 2018 12:24:22 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 01/12/2018 11:29 AM, Eric Blake wrote:
On 01/12/2018 08:55 AM, Marc-André Lureau wrote:
Hi

On Wed, Jan 10, 2018 at 7:35 PM, Stefan Berger
<address@hidden> wrote:
Implement a virtual memory device for the TPM physical
presence interface. The memory is located at 0xffff0000
and used by ACPI to send messages to the firmware (BIOS).

This device should be used by all TPM interfaces on x86 and
can be added through by calling tpm_ppi_init_io().

+#define DEBUG_PPI 1
to be switched to 0

+
+#define DPRINTF(fmt, ...) do { \
+    if (DEBUG_PPI) { \
+        printf(fmt, ## __VA_ARGS__); \
+    } \
+} while (0);
Also, this falls foul of my pending patch to forbid trailing semicolons
in do/while(0) macros:
https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg00246.html

But even though it is not a trace point, at least you made sure -Wformat
will avoid bit-rotting debug statements.

Fixing it.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]