Re: [Qemu-devel] [PATCH v2 0/7] target/m68k: supervisor mode (part 2)

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 0/7] target/m68k: supervisor mode (part 2)

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
9220bb87f5 target/m68k: add HMP command "info tlb"
b44e08dab0 target/m68k: add pflush/ptest
57cd7dca74 target/m68k: add moves
a050513d8b target/m68k: add index parameter to gen_load()/gen_store() and Co.
5dde4ae837 target/m68k: add Transparent Translation
af87360514 target/m68k: add MC68040 MMU
f316363523 accel/tcg: add size paremeter in tlb_fill()

=== OUTPUT BEGIN ===
Checking PATCH 1/7: accel/tcg: add size paremeter in tlb_fill()...
Checking PATCH 2/7: target/m68k: add MC68040 MMU...
Checking PATCH 3/7: target/m68k: add Transparent Translation...
Checking PATCH 4/7: target/m68k: add index parameter to gen_load()/gen_store() 
and Co....
ERROR: "foo * bar" should be "foo *bar"
#26: FILE: target/m68k/translate.c:284:
+static inline TCGv gen_load(DisasContext * s, int opsize, TCGv addr,

WARNING: line over 80 characters
#132: FILE: target/m68k/translate.c:945:
+static void gen_load_fp(DisasContext *s, int opsize, TCGv addr, TCGv_ptr fp, 
int index)

WARNING: line over 80 characters
#145: FILE: target/m68k/translate.c:999:
+static void gen_store_fp(DisasContext *s, int opsize, TCGv addr, TCGv_ptr fp, 
int index)

WARNING: line over 80 characters
#421: FILE: target/m68k/translate.c:4850:
+        if (gen_ea_fp(env, s, insn, opsize, cpu_src, EA_STORE, IS_USER(s)) == 
-1) {

WARNING: line over 80 characters
#430: FILE: target/m68k/translate.c:4872:
+        if (gen_ea_fp(env, s, insn, opsize, cpu_src, EA_LOADS, IS_USER(s)) == 
-1) {

total: 1 errors, 4 warnings, 387 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/7: target/m68k: add moves...
Checking PATCH 6/7: target/m68k: add pflush/ptest...
Checking PATCH 7/7: target/m68k: add HMP command "info tlb"...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden