Re: [Qemu-devel] [PATCH v2 1/2] ppc: Change Power9 compat table to support at most 8 threads/core

[David Gibson]

On Sun, Jan 14, 2018 at 05:23:48PM -0200, Jose Ricardo Ziviani wrote:
> Increases the max smt mode to 8 for Power9. That's because KVM supports
> smt emulation in this platform so QEMU should allow users to use it as
> well.
> 
> Today if we try to pass -smp ...,threads=8, QEMU will silently truncate
> it to smt4 mode and may cause a crash if we try to perform a cpu
> hotplug.
> 
> Signed-off-by: Jose Ricardo Ziviani <address@hidden>

Applied, with the addition of a comment explaining why we want this
despite the hardware limit.

> ---
>  target/ppc/compat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/ppc/compat.c b/target/ppc/compat.c
> index ad8f93c064..d1770cdc6f 100644
> --- a/target/ppc/compat.c
> +++ b/target/ppc/compat.c
> @@ -73,7 +73,7 @@ static const CompatInfo compat_table[] = {
>          .pvr = CPU_POWERPC_LOGICAL_3_00,
>          .pcr = PCR_COMPAT_3_00,
>          .pcr_level = PCR_COMPAT_3_00,
> -        .max_threads = 4,
> +        .max_threads = 8,
>      },
>  };
>  

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature