qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 13/13] docker: change Fedora images to run wi


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH v3 13/13] docker: change Fedora images to run with python3
Date: Mon, 15 Jan 2018 07:47:29 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

Hi Daniel,

On 01/15/2018 07:26 AM, Daniel P. Berrange wrote:
> Fedora has switched to Python 3 by default, so it makes sense to use that
> for testing QEMU builds, so we get testing of Python 3 compatibility.

I'd rather keep Fedora 25 with Python 2, and use Python 3 in Fedora 27.

If you agree, I can apply this patch once your series is merged, on top
of http://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg02569.html

relevant patches:
http://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg02574.html
http://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg02575.html

> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  tests/docker/dockerfiles/fedora.docker | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/docker/dockerfiles/fedora.docker 
> b/tests/docker/dockerfiles/fedora.docker
> index 4b26c3aded..a22fe16157 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -1,6 +1,6 @@
>  FROM fedora:latest
>  ENV PACKAGES \
> -    ccache gettext git tar PyYAML sparse flex bison python2 bzip2 hostname \
> +    ccache gettext git tar PyYAML sparse flex bison python3 bzip2 hostname \
>      glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
>      gcc gcc-c++ clang make perl which bc findutils libaio-devel \
>      nettle-devel \
> @@ -12,6 +12,7 @@ ENV PACKAGES \
>      mingw64-gtk2 mingw64-gtk3 mingw64-gnutls mingw64-nettle mingw64-libtasn1 
> \
>      mingw64-libjpeg-turbo mingw64-libpng mingw64-curl mingw64-libssh2 \
>      mingw64-bzip2
> +ENV QEMU_CONFIGURE_OPTS --python=/usr/bin/python3
>  
>  RUN dnf install -y $PACKAGES
>  RUN rpm -q $PACKAGES | sort > /packages.txt
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]