qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 04/13] qapi: Adapt to moved location of 'make


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v4 04/13] qapi: Adapt to moved location of 'maketrans' function in py3
Date: Mon, 15 Jan 2018 11:18:24 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 01/15/2018 11:02 AM, Daniel P. Berrange wrote:
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  scripts/qapi.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <address@hidden>

> 
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index 514cca44bf..1fdd189c0d 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -1734,7 +1734,10 @@ def c_enum_const(type_name, const_name, prefix=None):
>          type_name = prefix
>      return camel_to_upper(type_name) + '_' + c_name(const_name, 
> False).upper()
>  
> -c_name_trans = string.maketrans('.-', '__')
> +if hasattr(str, 'maketrans'):
> +    c_name_trans = str.maketrans('.-', '__')
> +else:
> +    c_name_trans = string.maketrans('.-', '__')
>  
>  
>  # Map @name to a valid C identifier.
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]