[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v9 23/26] target/arm: Use vector infrastructure for
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v9 23/26] target/arm: Use vector infrastructure for aa64 widening shifts |
Date: |
Mon, 15 Jan 2018 19:34:01 -0800 |
Signed-off-by: Richard Henderson <address@hidden>
---
target/arm/translate-a64.c | 29 ++++++++++++-----------------
1 file changed, 12 insertions(+), 17 deletions(-)
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 48caba3d9f..4f15e58556 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -8705,12 +8705,7 @@ static void handle_vec_simd_wshli(DisasContext *s, bool
is_q, bool is_u,
int size = 32 - clz32(immh) - 1;
int immhb = immh << 3 | immb;
int shift = immhb - (8 << size);
- int dsize = 64;
- int esize = 8 << size;
- int elements = dsize/esize;
- TCGv_i64 tcg_rn = new_tmp_a64(s);
- TCGv_i64 tcg_rd = new_tmp_a64(s);
- int i;
+ GVecGen2Fn *gvec_fn;
if (size >= 3) {
unallocated_encoding(s);
@@ -8721,18 +8716,18 @@ static void handle_vec_simd_wshli(DisasContext *s, bool
is_q, bool is_u,
return;
}
- /* For the LL variants the store is larger than the load,
- * so if rd == rn we would overwrite parts of our input.
- * So load everything right now and use shifts in the main loop.
- */
- read_vec_element(s, tcg_rn, rn, is_q ? 1 : 0, MO_64);
-
- for (i = 0; i < elements; i++) {
- tcg_gen_shri_i64(tcg_rd, tcg_rn, i * esize);
- ext_and_shift_reg(tcg_rd, tcg_rd, size | (!is_u << 2), 0);
- tcg_gen_shli_i64(tcg_rd, tcg_rd, shift);
- write_vec_element(s, tcg_rd, rd, i, size + 1);
+ if (is_u) {
+ gvec_fn = is_q ? tcg_gen_gvec_extuh : tcg_gen_gvec_extul;
+ } else {
+ gvec_fn = is_q ? tcg_gen_gvec_extsh : tcg_gen_gvec_extsl;
}
+ gvec_fn(size, vec_full_reg_offset(s, rd),
+ vec_full_reg_offset(s, rn), 16, 16);
+
+ /* Perform the shift in the wider format. */
+ tcg_gen_gvec_shli(size + 1, vec_full_reg_offset(s, rd),
+ vec_full_reg_offset(s, rd),
+ 16, vec_full_reg_size(s), shift);
}
/* SHRN/RSHRN - Shift right with narrowing (and potential rounding) */
--
2.14.3
- [Qemu-devel] [PATCH v9 13/26] tcg: Add generic vector helpers with a scalar variable operand, (continued)
- [Qemu-devel] [PATCH v9 13/26] tcg: Add generic vector helpers with a scalar variable operand, Richard Henderson, 2018/01/15
- [Qemu-devel] [PATCH v9 12/26] tcg: Add generic vector helpers with a scalar immediate operand, Richard Henderson, 2018/01/15
- [Qemu-devel] [PATCH v9 14/26] tcg/optimize: Handle vector opcodes during optimize, Richard Henderson, 2018/01/15
- [Qemu-devel] [PATCH v9 15/26] target/arm: Align vector registers, Richard Henderson, 2018/01/15
- [Qemu-devel] [PATCH v9 16/26] target/arm: Use vector infrastructure for aa64 add/sub/logic, Richard Henderson, 2018/01/15
- [Qemu-devel] [PATCH v9 17/26] target/arm: Use vector infrastructure for aa64 mov/not/neg, Richard Henderson, 2018/01/15
- [Qemu-devel] [PATCH v9 18/26] target/arm: Use vector infrastructure for aa64 dup/movi, Richard Henderson, 2018/01/15
- [Qemu-devel] [PATCH v9 19/26] target/arm: Use vector infrastructure for aa64 zip/uzp/trn/xtn, Richard Henderson, 2018/01/15
- [Qemu-devel] [PATCH v9 21/26] target/arm: Use vector infrastructure for aa64 compares, Richard Henderson, 2018/01/15
- [Qemu-devel] [PATCH v9 20/26] target/arm: Use vector infrastructure for aa64 constant shifts, Richard Henderson, 2018/01/15
- [Qemu-devel] [PATCH v9 23/26] target/arm: Use vector infrastructure for aa64 widening shifts,
Richard Henderson <=
- [Qemu-devel] [PATCH v9 22/26] target/arm: Use vector infrastructure for aa64 multiplies, Richard Henderson, 2018/01/15
- [Qemu-devel] [PATCH v9 24/26] target/arm: Use vector infrastructure for aa64 orr/bic immediate, Richard Henderson, 2018/01/15
- [Qemu-devel] [PATCH v9 26/26] tcg/aarch64: Add vector operations, Richard Henderson, 2018/01/15
- [Qemu-devel] [PATCH v9 25/26] tcg/i386: Add vector operations, Richard Henderson, 2018/01/15
- Re: [Qemu-devel] [PATCH v9 00/26] tcg: generic vector operations, no-reply, 2018/01/15
- Re: [Qemu-devel] [PATCH v9 00/26] tcg: generic vector operations, no-reply, 2018/01/16
- Re: [Qemu-devel] [PATCH v9 00/26] tcg: generic vector operations, Peter Maydell, 2018/01/16