Re: [Qemu-devel] [PULL v4 00/51] Misc patches for 2018-01-12

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL v4 00/51] Misc patches for 2018-01-12

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   f521eeee3b..aae39d24a3  master     -> master
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
8d5c19ee59 scripts/analyse-locks-simpletrace.py: script to analyse lock times
028b489871 util/qemu-thread-*: add qemu_lock, locked and unlock trace events
9ce469b8d3 cpu: flush TB cache when loading VMState
4592c6fc6d block/iscsi: fix initialization of iTask in iscsi_co_get_block_status
a7a80362bd find_ram_offset: Align ram_addr_t allocation on long boundaries
c266ee51cb find_ram_offset: Add comments and tracing
5a28d83034 cpu_physical_memory_sync_dirty_bitmap: Another alignment fix
20c5869514 checkpatch: Enforce proper do/while (0) style
dba6450c75 maint: Fix macros with broken 'do/while(0); ' usage
f72687a888 tests: Avoid 'do/while(false); ' in vhost-user-bridge
67da9bdd04 chardev: Clean up previous patch indentation
0b44cbe552 chardev: Use goto/label instead of do/break/while(0)
ea2267eedc mips: Tweak location of ';' in macros
b5c31718fd net: Drop unusual use of do { } while (0);
6d4c84238c irq: fix memory leak
9d097a6f41 cpus: unify qemu_*_wait_io_event
3ad828c271 icount: fixed saving/restoring of icount warp timers
d27d206657 scripts/qemu-gdb/timers.py: new helper to dump timer state
021b13fc18 scripts/qemu-gdb: add simple tcg lock status helper
788d5b6c8e target-i386: update hflags on Hypervisor.framework
2fe60e00e4 target/i386: hax: Move x86_update_hflags.
8bcf5f332d target/i386: hax: change to use x86_update_hflags
abe8ba0b29 target/i386: move hflags update code to a function
d10c944178 tests/boot-serial-test: Add support for the raspi2 machine
88b6c83db5 tests/boot-serial-test: Add a test for the moxiesim machine
1d6145e7dc tests/boot-serial-test: Add tests for microblaze boards
e71edbe725 scsi-disk: release AioContext in unaligned WRITE SAME case
566948dd91 disas/s390: fix global-buffer-overflow
ae42cef294 mips: fix potential fopen(NULL,...)
ca10a2cbd7 tests: fix coroutine leak in /basic/entered
788c04ecb8 tests: fix qmp-test leak
57b28cdb84 qemu-config: fix leak in query-command-line-options
773fc2f2ae crypto: fix stack-buffer-overflow error
4bb5d62a8b readline: add a free function
0b7ad27179 vl: fix direct firmware directories leak
81af850214 tests: fix check-qobject leak
a528620674 tests/docker: add test-debug
ff0f14b5f3 tests/docker: add some sanitizers to fedora dockerfile
1a4bbc821a build-sys: compile with -Og or -O1 when --enable-debug
51296ac14a build-sys: add a rule to print a variable
d632afdb14 build-sys: silence make by default or V=0
5921b3610c build-sys: fix qemu-ga -pthread linking
e8c1a6984a chardev: introduce qemu_chr_timeout_add_ms()
78b11ee7fd chardev: let g_idle_add() be with chardev gcontext
72841e0936 chardev: use backend chr context when watch for fe
6513afa645 i386/cpu/kvm: look at PMU's CPUID before setting MSRs
f21a1e10fc hpet: recover timer offset correctly
9cf6f5f07f pc: fail memory hot-plug/unplug with -no-acpi and Q35 machine type
7fa434aec1 scsi: fix scsi_convert_sense crash when in_buf == NULL && in_len == 0
cdae3dd6aa scsi-generic: Add share-rw option

=== OUTPUT BEGIN ===
Checking PATCH 1/50: scsi-generic: Add share-rw option...
Checking PATCH 2/50: scsi: fix scsi_convert_sense crash when in_buf == NULL && 
in_len == 0...
Checking PATCH 3/50: pc: fail memory hot-plug/unplug with -no-acpi and Q35 
machine type...
Checking PATCH 4/50: hpet: recover timer offset correctly...
Checking PATCH 5/50: i386/cpu/kvm: look at PMU's CPUID before setting MSRs...
Checking PATCH 6/50: chardev: use backend chr context when watch for fe...
Checking PATCH 7/50: chardev: let g_idle_add() be with chardev gcontext...
Checking PATCH 8/50: chardev: introduce qemu_chr_timeout_add_ms()...
Checking PATCH 9/50: build-sys: fix qemu-ga -pthread linking...
Checking PATCH 10/50: build-sys: silence make by default or V=0...
Checking PATCH 11/50: build-sys: add a rule to print a variable...
Checking PATCH 12/50: build-sys: compile with -Og or -O1 when --enable-debug...
Checking PATCH 13/50: tests/docker: add some sanitizers to fedora dockerfile...
Checking PATCH 14/50: tests/docker: add test-debug...
Checking PATCH 15/50: tests: fix check-qobject leak...
Checking PATCH 16/50: vl: fix direct firmware directories leak...
Checking PATCH 17/50: readline: add a free function...
Checking PATCH 18/50: crypto: fix stack-buffer-overflow error...
Checking PATCH 19/50: qemu-config: fix leak in query-command-line-options...
Checking PATCH 20/50: tests: fix qmp-test leak...
Checking PATCH 21/50: tests: fix coroutine leak in /basic/entered...
Checking PATCH 22/50: mips: fix potential fopen(NULL,...)...
Checking PATCH 23/50: disas/s390: fix global-buffer-overflow...
ERROR: braces {} are necessary even for single statement blocks
#85: FILE: disas/s390.c:216:
+  for (i = s390_num_opcodes; i--; )
+    opc_index[s390_opcodes[i].opcode[0]] = i;

total: 1 errors, 0 warnings, 24 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 24/50: scsi-disk: release AioContext in unaligned WRITE SAME 
case...
Checking PATCH 25/50: tests/boot-serial-test: Add tests for microblaze boards...
Checking PATCH 26/50: tests/boot-serial-test: Add a test for the moxiesim 
machine...
Checking PATCH 27/50: tests/boot-serial-test: Add support for the raspi2 
machine...
Checking PATCH 28/50: target/i386: move hflags update code to a function...
ERROR: Macros with complex values should be enclosed in parenthesis
#24: FILE: target/i386/cpu.c:4153:
+#define HFLAG_COPY_MASK \
+    ~( HF_CPL_MASK | HF_PE_MASK | HF_MP_MASK | HF_EM_MASK | \
+       HF_TS_MASK | HF_TF_MASK | HF_VM_MASK | HF_IOPL_MASK | \
+       HF_OSFXSR_MASK | HF_LMA_MASK | HF_CS32_MASK | \
+       HF_SS32_MASK | HF_CS64_MASK | HF_ADDSEG_MASK)

ERROR: space prohibited after that open parenthesis '('
#25: FILE: target/i386/cpu.c:4154:
+    ~( HF_CPL_MASK | HF_PE_MASK | HF_MP_MASK | HF_EM_MASK | \

ERROR: "foo* bar" should be "foo *bar"
#74: FILE: target/i386/cpu.h:1781:
+void x86_update_hflags(CPUX86State* env);

total: 3 errors, 0 warnings, 106 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 29/50: target/i386: hax: change to use x86_update_hflags...
Checking PATCH 30/50: target/i386: hax: Move x86_update_hflags....
Checking PATCH 31/50: target-i386: update hflags on Hypervisor.framework...
Checking PATCH 32/50: scripts/qemu-gdb: add simple tcg lock status helper...
Checking PATCH 33/50: scripts/qemu-gdb/timers.py: new helper to dump timer 
state...
Checking PATCH 34/50: icount: fixed saving/restoring of icount warp timers...
ERROR: spaces required around that '*' (ctx:VxV)
#172: FILE: cpus.c:689:
+    .subsections = (const VMStateDescription*[]) {
                                             ^

total: 1 errors, 0 warnings, 173 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 35/50: cpus: unify qemu_*_wait_io_event...
Checking PATCH 36/50: irq: fix memory leak...
Checking PATCH 37/50: net: Drop unusual use of do { } while (0);...
Checking PATCH 38/50: mips: Tweak location of ';' in macros...
Checking PATCH 39/50: chardev: Use goto/label instead of do/break/while(0)...
Checking PATCH 40/50: chardev: Clean up previous patch indentation...
Checking PATCH 41/50: tests: Avoid 'do/while(false); ' in vhost-user-bridge...
Checking PATCH 42/50: maint: Fix macros with broken 'do/while(0); ' usage...
Checking PATCH 43/50: checkpatch: Enforce proper do/while (0) style...
Checking PATCH 44/50: cpu_physical_memory_sync_dirty_bitmap: Another alignment 
fix...
Checking PATCH 45/50: find_ram_offset: Add comments and tracing...
Checking PATCH 46/50: find_ram_offset: Align ram_addr_t allocation on long 
boundaries...
Checking PATCH 47/50: block/iscsi: fix initialization of iTask in 
iscsi_co_get_block_status...
Checking PATCH 48/50: cpu: flush TB cache when loading VMState...
Checking PATCH 49/50: util/qemu-thread-*: add qemu_lock, locked and unlock 
trace events...
ERROR: line over 90 characters
#132: FILE: util/qemu-thread-posix.c:158:
+void qemu_cond_wait_impl(QemuCond *cond, QemuMutex *mutex, const char *file, 
const int line)

ERROR: line over 90 characters
#193: FILE: util/qemu-thread-win32.c:145:
+void qemu_cond_wait_impl(QemuCond *cond, QemuMutex *mutex, const char *file, 
const int line)

total: 2 errors, 0 warnings, 181 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 50/50: scripts/analyse-locks-simpletrace.py: script to analyse 
lock times...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden