Re: [Qemu-devel] [PATCH v2 4/4] linux-user: MIPS set cpu to r6 CPU if binary is R6

[Laurent Vivier]

Le 16/01/2018 à 21:26, Richard Henderson a écrit :
> On 01/16/2018 09:25 AM, Laurent Vivier wrote:
>> From: YunQiang Su <address@hidden>
>>
>> So here we need to detect the version of binaries and set
>> cpu_model for it.
>>
>> [lv: original patch modified to move code into cpu_get_model()]
>> Signed-off-by: Laurent Vivier <address@hidden>
>> ---
> 
> Reviewed-by: Richard Henderson <address@hidden>
> 
>>  static inline const char *cpu_get_model(uint32_t eflags)
>>  {
>> +     if ((eflags & EF_MIPS_ARCH_32R6) != 0) {
>> +         return "mips32r6-generic";
>> +     }
>>      return "24Kf";
> 
> That said, I don't suppose it's worth diagnosing cases that we can't support
> somehow?  E.g. mips-linux-user and EF_MIPS_ARCH_64.  Or even coldfire ISA-C.

Yes, the idea is "if we don't know, do as before":
the real error will be reported by the loader.

Thanks,
Laurent