Re: [Qemu-devel] [PATCH v2 6/8] docker: add the Fedora 27 base image

[Fam Zheng]

On Tue, Jan 16, 2018 at 12:38 AM, Philippe Mathieu-Daudé
<address@hidden> wrote:
> On 01/15/2018 01:27 PM, Daniel P. Berrange wrote:
>> On Mon, Jan 15, 2018 at 11:34:57AM -0300, Philippe Mathieu-Daudé wrote:
>>> straight copy on Fedora 25 base.
>>>
>>> Suggested-by: Paolo Bonzini <address@hidden>
>>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>>> ---
>>>  tests/docker/dockerfiles/fedora27.docker | 18 ++++++++++++++++++
>>>  1 file changed, 18 insertions(+)
>>>  create mode 100644 tests/docker/dockerfiles/fedora27.docker
>>>
>>> diff --git a/tests/docker/dockerfiles/fedora27.docker 
>>> b/tests/docker/dockerfiles/fedora27.docker
>>> new file mode 100644
>>> index 0000000000..7cba4dcc2c
>>> --- /dev/null
>>> +++ b/tests/docker/dockerfiles/fedora27.docker
>>> @@ -0,0 +1,18 @@
>>> +FROM fedora:27
>>> +ENV PACKAGES \
>>> +    ccache gettext git tar PyYAML sparse flex bison python2 bzip2 hostname 
>>> \
>>> +    glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
>>
>> Perhaps SDL2 here too
>>
>>> +    gcc gcc-c++ clang make perl which bc findutils libaio-devel \
>>> +    nettle-devel \
>>> +    mingw32-pixman mingw32-glib2 mingw32-gmp mingw32-SDL 
>>> mingw32-pkg-config \
>>> +    mingw32-gtk2 mingw32-gtk3 mingw32-gnutls mingw32-nettle 
>>> mingw32-libtasn1 \
>>
>> Is there a reason we have both GTK2 and GTK3 installed ? We've deprecated 
>> GTK2
>> and configure will pick GTK3 by default. IIUC there's no way to override
>> that in the docker builds to force GTK2, so it can possibly be dropped.
>
> No clue, Fam?
>

I think Dan is right here.

Fam