[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v10 05/21] tcg: Loosen vec_gen_op* typecheck rules
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v10 05/21] tcg: Loosen vec_gen_op* typecheck rules |
Date: |
Wed, 17 Jan 2018 08:09:17 -0800 |
For ARM SVE with VQ=3, we want to be able to dup a scalar
into a v256, use that, and then perform a second operation
with the v256 punned to a v128.
Allow operands to a vector operation be wider than necessary
for the output.
Signed-off-by: Richard Henderson <address@hidden>
---
tcg/tcg-op-vec.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/tcg/tcg-op-vec.c b/tcg/tcg-op-vec.c
index 5cfe4af6bd..97b437e41a 100644
--- a/tcg/tcg-op-vec.c
+++ b/tcg/tcg-op-vec.c
@@ -78,7 +78,8 @@ static void vec_gen_op2(TCGOpcode opc, unsigned vece,
TCGv_vec r, TCGv_vec a)
TCGTemp *at = tcgv_vec_temp(a);
TCGType type = rt->base_type;
- tcg_debug_assert(at->base_type == type);
+ /* Must enough inputs for the output. */
+ tcg_debug_assert(at->base_type >= type);
vec_gen_2(opc, type, vece, temp_arg(rt), temp_arg(at));
}
@@ -90,8 +91,9 @@ static void vec_gen_op3(TCGOpcode opc, unsigned vece,
TCGTemp *bt = tcgv_vec_temp(b);
TCGType type = rt->base_type;
- tcg_debug_assert(at->base_type == type);
- tcg_debug_assert(bt->base_type == type);
+ /* Must enough inputs for the output. */
+ tcg_debug_assert(at->base_type >= type);
+ tcg_debug_assert(bt->base_type >= type);
vec_gen_3(opc, type, vece, temp_arg(rt), temp_arg(at), temp_arg(bt));
}
@@ -257,14 +259,14 @@ void tcg_gen_dup_i64_vec(unsigned vece, TCGv_vec r,
TCGv_i64 a)
if (TCG_TARGET_REG_BITS == 64) {
TCGArg ai = tcgv_i64_arg(a);
- vec_gen_2(INDEX_op_dup_vec, type, MO_64, ri, ai);
+ vec_gen_2(INDEX_op_dup_vec, type, vece, ri, ai);
} else if (vece == MO_64) {
TCGArg al = tcgv_i32_arg(TCGV_LOW(a));
TCGArg ah = tcgv_i32_arg(TCGV_HIGH(a));
vec_gen_3(INDEX_op_dup2_vec, type, MO_64, ri, al, ah);
} else {
TCGArg ai = tcgv_i32_arg(TCGV_LOW(a));
- vec_gen_2(INDEX_op_dup_vec, type, MO_64, ri, ai);
+ vec_gen_2(INDEX_op_dup_vec, type, vece, ri, ai);
}
}
--
2.14.3
- [Qemu-devel] [PATCH v10 00/21] tcg: generic vector operations, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10 03/21] tcg: Standardize integral arguments to expanders, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10 01/21] tcg: Allow multiple word entries into the constant pool, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10 02/21] tcg: Add types and basic operations for host vectors, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10 05/21] tcg: Loosen vec_gen_op* typecheck rules,
Richard Henderson <=
- [Qemu-devel] [PATCH v10 06/21] tcg: Add generic vector ops for constant shifts, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10 07/21] tcg: Add generic vector ops for comparisons, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10 08/21] tcg: Add generic vector ops for multiplication, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10 09/21] tcg: Add generic helpers for saturating arithmetic, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10 04/21] tcg: Add generic vector expanders, Richard Henderson, 2018/01/17