[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4) |
Date: |
Wed, 17 Jan 2018 16:12:09 +0000 |
On 17 January 2018 at 15:43, Igor Mammedov <address@hidden> wrote:
> Series is finishing work on generalizing cpu_model parsing
> and limiting parts that deal with inconsistent cpu_model
> naming to "-cpu" CLI option processing in vl.c/*-user.main.c
> and FOO_cpu_class_by_name() callbacks.
>
> It introduces TARGET_DEFAULT_CPU_TYPE which must be defined
> by each target and is used setting default cpu type for
> linux/bsd-user targets and as anchor point to pick cpu class
> that provides target specific FOO_cpu_class_by_name()
> callback for cpu_parse_cpu_model() in null-machine.c
> which is compiled for all targets that have system
> mode emulation.
I like moving this from being an ifdef ladder into per-cpu
code, but I don't think the definition belongs in target/$ARCH.
It's part of the choice usermode makes about how to handle
binaries it's loading, so it should go in linux-user/$ARCH/target_cpu.h.
target/$ARCH should really be for things that are properties
of the architecture.
thanks
-- PMM
- [Qemu-devel] [PATCH 18/24] hppa: cpu: add TARGET_DEFAULT_CPU_TYPE macro, (continued)
- [Qemu-devel] [PATCH 18/24] hppa: cpu: add TARGET_DEFAULT_CPU_TYPE macro, Igor Mammedov, 2018/01/17
- [Qemu-devel] [PATCH 21/24] linux/bsd-user: drop cpu_init() and use cpu_create() instead, Igor Mammedov, 2018/01/17
- [Qemu-devel] [PATCH 20/24] machine: drop MachineState::cpu_model, Igor Mammedov, 2018/01/17
- [Qemu-devel] [PATCH 23/24] nios2: 10m50_devboard: replace cpu_model with cpu_type, Igor Mammedov, 2018/01/17
- [Qemu-devel] [PATCH 24/24] cpu: get rid of cpu_generic_init(), Igor Mammedov, 2018/01/17
- [Qemu-devel] [PATCH 22/24] cpu: get rid of unused cpu_init() defines, Igor Mammedov, 2018/01/17
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4),
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Igor Mammedov, 2018/01/17
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Peter Maydell, 2018/01/17
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Igor Mammedov, 2018/01/18
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Peter Maydell, 2018/01/18
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Igor Mammedov, 2018/01/18
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Peter Maydell, 2018/01/18
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Igor Mammedov, 2018/01/18
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Peter Maydell, 2018/01/18
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Igor Mammedov, 2018/01/18
- Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4), Peter Maydell, 2018/01/18