[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/7] Call check and invalidate_cache from cor
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/7] Call check and invalidate_cache from coroutine context |
Date: |
Thu, 18 Jan 2018 14:25:26 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/18/2018 06:43 AM, Paolo Bonzini wrote:
> Check and invalidate_cache share some parts of the implementation
> with the regular I/O path. This is sometimes complicated because the
> I/O path wants to use a CoMutex but that is not possible outside coroutine
> context. By moving things to coroutine context, we can remove special
> cases. In fact, invalidate_cache is already called from coroutine context
> because incoming migration is placed in a coroutine.
>
> While at it, I'm including two patches from Stefan to rename the
> bdrv_create callback to bdrv_co_create, because it is already called
> from coroutine context. The name is now bdrv_co_create_opts, with
> bdrv_co_create reserved for the QAPI-based version that Kevin is
> working on.
>
> qcow2 still has cache flushing in non-coroutine context, coming from
> qcow2_reopen_prepare->qcow2_update_options_prepare and
> qcow2_close->qcow2_inactivate.
>
> Paolo
>
Modulo a commit message nit in 4/7, series
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 0/7] Call check and invalidate_cache from coroutine context, Paolo Bonzini, 2018/01/18
- [Qemu-devel] [PATCH 2/7] qcow2: make qcow2_co_create2() a coroutine_fn, Paolo Bonzini, 2018/01/18
- [Qemu-devel] [PATCH 3/7] qcow2: make qcow2_do_open a coroutine_fn, Paolo Bonzini, 2018/01/18
- [Qemu-devel] [PATCH 4/7] qed: make bdrv_qed_do_open a coroutine_fn, Paolo Bonzini, 2018/01/18
- [Qemu-devel] [PATCH 1/7] block: rename .bdrv_create() to .bdrv_co_create_opts(), Paolo Bonzini, 2018/01/18
- [Qemu-devel] [PATCH 6/7] qcow2: introduce qcow2_write_caches and qcow2_flush_caches, Paolo Bonzini, 2018/01/18
- [Qemu-devel] [PATCH 7/7] block: convert bdrv_check callback to coroutine_fn, Paolo Bonzini, 2018/01/18
- [Qemu-devel] [PATCH 5/7] block: convert bdrv_invalidate_cache callback to coroutine_fn, Paolo Bonzini, 2018/01/18
- Re: [Qemu-devel] [PATCH v3 0/7] Call check and invalidate_cache from coroutine context,
Eric Blake <=