[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] allow to build with older sed
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] allow to build with older sed |
Date: |
Fri, 19 Jan 2018 08:37:53 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/19/2018 01:52 AM, Jan Beulich wrote:
> sed's -E option may not be supported by older distros. As there's no
> point using sed here at all, use just shell mechanisms to establish the
> variable values, starting from the stem instead of the full target.
Grammar in the subject ("allow to ${verb}" is not idiomatic, better is
"allow ${subject} to ${verb}" or "allow ${verb}ing"):
s/to build/building/
Reviewed-by: Eric Blake <address@hidden>
>
> Signed-off-by: Jan Beulich <address@hidden>
>
> --- a/Makefile
> +++ b/Makefile
> @@ -242,8 +242,7 @@ GENERATED_FILES += $(KEYCODEMAP_FILES)
>
> ui/input-keymap-%.c: $(KEYCODEMAP_GEN) $(KEYCODEMAP_CSV)
> $(SRC_PATH)/ui/Makefile.objs
> $(call quiet-command,\
> - src=$$(echo $@ | sed -E -e
> "s,^ui/input-keymap-(.+)-to-(.+)\.c$$,\1,") && \
> - dst=$$(echo $@ | sed -E -e
> "s,^ui/input-keymap-(.+)-to-(.+)\.c$$,\2,") && \
> + stem=$* && src=$${stem%-to-*} dst=$${stem#*-to-} && \
> test -e $(KEYCODEMAP_GEN) && \
> $(PYTHON) $(KEYCODEMAP_GEN) \
> --lang glib2 \
>
>
>
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature