[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/6] block/dirty-bitmap: add lock to bdrv_ena
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/6] block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap |
Date: |
Fri, 19 Jan 2018 18:45:31 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/16/2018 07:54 AM, Vladimir Sementsov-Ogievskiy wrote:
> Add locks and remove comments about BQL accordingly to
> dirty_bitmap_mutex definition in block_int.h.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> block/dirty-bitmap.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
> index 3777be1985..d0a10c4f5d 100644
> --- a/block/dirty-bitmap.c
> +++ b/block/dirty-bitmap.c
> @@ -389,18 +389,20 @@ void
> bdrv_remove_persistent_dirty_bitmap(BlockDriverState *bs,
> }
> }
>
> -/* Called with BQL taken. */
> void bdrv_disable_dirty_bitmap(BdrvDirtyBitmap *bitmap)
> {
> + bdrv_dirty_bitmap_lock(bitmap);
> assert(!bdrv_dirty_bitmap_frozen(bitmap));
> bitmap->disabled = true;
> + bdrv_dirty_bitmap_unlock(bitmap);
> }
>
> -/* Called with BQL taken. */
> void bdrv_enable_dirty_bitmap(BdrvDirtyBitmap *bitmap)
> {
> + bdrv_dirty_bitmap_lock(bitmap);
> assert(!bdrv_dirty_bitmap_frozen(bitmap));
> bitmap->disabled = false;
> + bdrv_dirty_bitmap_unlock(bitmap);
> }
>
> BlockDirtyInfoList *bdrv_query_dirty_bitmaps(BlockDriverState *bs)
>
Reviewed-by: John Snow <address@hidden>
- [Qemu-devel] [PATCH v2 0/6] qmp dirty bitmap API, Vladimir Sementsov-Ogievskiy, 2018/01/16
- [Qemu-devel] [PATCH v2 6/6] qapi: add disabled parameter to block-dirty-bitmap-add, Vladimir Sementsov-Ogievskiy, 2018/01/16
- [Qemu-devel] [PATCH v2 5/6] qapi: add block-dirty-bitmap-merge, Vladimir Sementsov-Ogievskiy, 2018/01/16
- [Qemu-devel] [PATCH v2 2/6] block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap, Vladimir Sementsov-Ogievskiy, 2018/01/16
- Re: [Qemu-devel] [PATCH v2 2/6] block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap,
John Snow <=
- [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable, Vladimir Sementsov-Ogievskiy, 2018/01/16
[Qemu-devel] [PATCH v2 1/6] block: maintain persistent disabled bitmaps, Vladimir Sementsov-Ogievskiy, 2018/01/16
Re: [Qemu-devel] [PATCH v2 0/6] qmp dirty bitmap API, John Snow, 2018/01/19