[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/7] Revert "target/mips: hold BQL for timer int
|
From: |
Aleksandar Markovic |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/7] Revert "target/mips: hold BQL for timer interrupts" |
|
Date: |
Mon, 22 Jan 2018 15:18:05 +0000 |
> From: Alex Bennée address@hidden
>
> > From: Aleksandar Markovic <address@hidden>
> >
> > This reverts commit d394698d73836d1c50545bdb32dc58d09708fcfb.
> >
> > Ther revert is needed in order not to cause overlap with subsequent
> > patches related to handling synchronization of interrupt code paths.
>
> Hmm I'm fairly sure you should merge this with the follow-up patch to
> add BQL locking to the appropriate place. Otherwise you break
> bi-section.
Thanks for the review, Alex!
You are right, the bisect would have been broken. I am going to merge this and
subsequent patch in v2.
I am going to address all your other concerns in v2 as well.
Regards,
Aleksandar
- [Qemu-devel] [PATCH 4/7] hw/mips_int: hold BQL for all interrupt requests, (continued)
- [Qemu-devel] [PATCH 4/7] hw/mips_int: hold BQL for all interrupt requests, Aleksandar Markovic, 2018/01/19
- [Qemu-devel] [PATCH 6/7] hw/mips_cpc: kick a VP when putting it into Run state, Aleksandar Markovic, 2018/01/19
- [Qemu-devel] [PATCH 5/7] target/mips: hold BQL in mips_vpe_wake(), Aleksandar Markovic, 2018/01/19
- [Qemu-devel] [PATCH 1/7] target/mips: compare virtual addresses in LL/SC sequence, Aleksandar Markovic, 2018/01/19
- [Qemu-devel] [PATCH 2/7] target/mips: reimplement SC instruction and use cmpxchg, Aleksandar Markovic, 2018/01/19
- [Qemu-devel] [PATCH 7/7] target/mips: introduce MTTCG-enabled builds, Aleksandar Markovic, 2018/01/19
- [Qemu-devel] [PATCH 3/7] Revert "target/mips: hold BQL for timer interrupts", Aleksandar Markovic, 2018/01/19