Re: [Qemu-devel] [PATCH v3 2/4] target/arm: implement SHA-3 instructions

[Peter Maydell]

On 19 January 2018 at 14:17, Ard Biesheuvel <address@hidden> wrote:
> This implements emulation of the new SHA-3 instructions that have
> been added as an optional extensions to the ARMv8 Crypto Extensions
> in ARM v8.2.
>
> Signed-off-by: Ard Biesheuvel <address@hidden>
> ---
>  target/arm/cpu.h           |   1 +
>  target/arm/crypto_helper.c |  69 +++++++++++++
>  target/arm/helper.h        |   5 +
>  target/arm/translate-a64.c | 108 +++++++++++++++++++-
>  4 files changed, 179 insertions(+), 4 deletions(-)
>
> diff --git a/target/arm/cpu.h b/target/arm/cpu.h
> index 295529366c0a..8e355398e3e0 100644
> --- a/target/arm/cpu.h
> +++ b/target/arm/cpu.h
> @@ -1341,6 +1341,7 @@ enum arm_features {
>      ARM_FEATURE_M_SECURITY, /* M profile Security Extension */
>      ARM_FEATURE_JAZELLE, /* has (trivial) Jazelle implementation */
>      ARM_FEATURE_V8_SHA512, /* implements SHA512 part of v8 Crypto Extensions 
> */
> +    ARM_FEATURE_V8_SHA3, /* implements SHA3 part of v8 Crypto Extensions */
>  };
>

> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
>  /* initialize TCG globals.  */
>  void a64_translate_init(void)
> @@ -11125,6 +11127,7 @@ static void 
> disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn)
>      int rn = extract32(insn, 5, 5);
>      int rd = extract32(insn, 0, 5);
>      TCGv_i32 tcg_rd_regno, tcg_rn_regno, tcg_rm_regno;
> +    int feature;
>      CryptoThreeOpEnvFn *genfn;
>
>      if (o != 0) {
> @@ -11134,20 +11137,24 @@ static void 
> disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn)
>
>      switch (opcode) {
>      case 0: /* SHA512H */
> +        feature = ARM_FEATURE_V8_SHA512;
>          genfn = gen_helper_crypto_sha512h;
>          break;
>      case 1: /* SHA512H2 */
> +        feature = ARM_FEATURE_V8_SHA512;
>          genfn = gen_helper_crypto_sha512h2;
>          break;
>      case 2: /* SHA512SU1 */
> +        feature = ARM_FEATURE_V8_SHA512;
>          genfn = gen_helper_crypto_sha512su1;
>          break;

I think these lines should have been in patch 1, right?

> -    default:
> -        unallocated_encoding(s);
> -        return;
> +    case 3: /* RAX1 */
> +        feature = ARM_FEATURE_V8_SHA3;
> +        genfn = gen_helper_crypto_rax1;
> +        break;
>      }
>
> -    if (!arm_dc_feature(s, ARM_FEATURE_V8_SHA512)) {
> +    if (!arm_dc_feature(s, feature)) {
>          unallocated_encoding(s);
>          return;

thanks
-- PMM