[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH v5 15/24] replay/replay-internal.c: track holdin
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [RFC PATCH v5 15/24] replay/replay-internal.c: track holding of replay_lock |
Date: |
Tue, 23 Jan 2018 11:54:43 +0300 |
User-agent: |
StGit/0.17.1-dirty |
From: Alex Bennée <address@hidden>
This is modelled after the iothread mutex lock. We keep a TLS flag to
indicate when that thread has acquired the lock and assert we don't
double-lock or release when we shouldn't have.
Signed-off-by: Alex Bennée <address@hidden>
Tested-by: Pavel Dovgalyuk <address@hidden>
---
replay/replay-internal.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/replay/replay-internal.c b/replay/replay-internal.c
index fca8514..157c863 100644
--- a/replay/replay-internal.c
+++ b/replay/replay-internal.c
@@ -179,13 +179,24 @@ void replay_mutex_destroy(void)
qemu_mutex_destroy(&lock);
}
+static __thread bool replay_locked;
+
+static bool replay_mutex_locked(void)
+{
+ return replay_locked;
+}
+
void replay_mutex_lock(void)
{
+ g_assert(!replay_mutex_locked());
qemu_mutex_lock(&lock);
+ replay_locked = true;
}
void replay_mutex_unlock(void)
{
+ g_assert(replay_mutex_locked());
+ replay_locked = false;
qemu_mutex_unlock(&lock);
}
- [Qemu-devel] [RFC PATCH v5 05/24] replay: fix processing async events, (continued)
- [Qemu-devel] [RFC PATCH v5 05/24] replay: fix processing async events, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 06/24] replay: fixed replay_enable_events, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 07/24] replay: fix save/load vm for non-empty queue, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 08/24] replay: added replay log format description, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 09/24] replay: save prior value of the host clock, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 10/24] target/arm/arm-powertctl: drop BQL assertions, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 11/24] cpus: push BQL lock to qemu_*_wait_io_event, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 12/24] hax: remove BQL lock/unlock, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 13/24] kvm: remove BQL lock/unlock, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 14/24] replay/replay.c: bump REPLAY_VERSION again, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 15/24] replay/replay-internal.c: track holding of replay_lock,
Pavel Dovgalyuk <=
- [Qemu-devel] [RFC PATCH v5 16/24] replay: make locking visible outside replay code, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 17/24] replay: push replay_mutex_lock up the call tree, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 18/24] replay: don't destroy mutex at exit, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 19/24] replay: check return values of fwrite, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 20/24] replay: avoid recursive call of checkpoints, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 22/24] replay: don't process async events when warping the clock, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 21/24] scripts/replay-dump.py: replay log dumper, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 23/24] replay: save vmstate of the asynchronous events, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 24/24] replay: don't drain/flush bdrv queue while RR is working, Pavel Dovgalyuk, 2018/01/23
- Re: [Qemu-devel] [RFC PATCH v5 00/24] replay additions, no-reply, 2018/01/23