[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH v5 22/24] replay: don't process async events whe
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [RFC PATCH v5 22/24] replay: don't process async events when warping the clock |
Date: |
Tue, 23 Jan 2018 11:55:22 +0300 |
User-agent: |
StGit/0.17.1-dirty |
Virtual clock is warped from iothread and vcpu thread. When the hardware
events associated with warp checkpoint, then interrupt delivering may be
non-deterministic if checkpoint is processed in different threads in record
and replay.
This patch disables event processing for clock warp checkpoint and leaves
all hardware events to other checkpoints (e.g., virtual clock).
Signed-off-by: Pavel Dovgalyuk <address@hidden>
--
v4: added assert for replay_save_events function
---
replay/replay-events.c | 1 +
replay/replay.c | 7 ++++++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/replay/replay-events.c b/replay/replay-events.c
index a941efb..18d769f 100644
--- a/replay/replay-events.c
+++ b/replay/replay-events.c
@@ -204,6 +204,7 @@ static void replay_save_event(Event *event, int checkpoint)
/* Called with replay mutex locked */
void replay_save_events(int checkpoint)
{
+ assert(checkpoint != CHECKPOINT_CLOCK_WARP_START);
while (!QTAILQ_EMPTY(&events_list)) {
Event *event = QTAILQ_FIRST(&events_list);
replay_save_event(event, checkpoint);
diff --git a/replay/replay.c b/replay/replay.c
index c676dd4..e3794fc 100644
--- a/replay/replay.c
+++ b/replay/replay.c
@@ -211,7 +211,12 @@ bool replay_checkpoint(ReplayCheckpoint checkpoint)
} else if (replay_mode == REPLAY_MODE_RECORD) {
g_assert(replay_mutex_locked());
replay_put_event(EVENT_CHECKPOINT + checkpoint);
- replay_save_events(checkpoint);
+ /* This checkpoint belongs to several threads.
+ Processing events from different threads is
+ non-deterministic */
+ if (checkpoint != CHECKPOINT_CLOCK_WARP_START) {
+ replay_save_events(checkpoint);
+ }
res = true;
}
out:
- [Qemu-devel] [RFC PATCH v5 11/24] cpus: push BQL lock to qemu_*_wait_io_event, (continued)
- [Qemu-devel] [RFC PATCH v5 11/24] cpus: push BQL lock to qemu_*_wait_io_event, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 12/24] hax: remove BQL lock/unlock, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 13/24] kvm: remove BQL lock/unlock, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 14/24] replay/replay.c: bump REPLAY_VERSION again, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 15/24] replay/replay-internal.c: track holding of replay_lock, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 16/24] replay: make locking visible outside replay code, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 17/24] replay: push replay_mutex_lock up the call tree, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 18/24] replay: don't destroy mutex at exit, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 19/24] replay: check return values of fwrite, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 20/24] replay: avoid recursive call of checkpoints, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 22/24] replay: don't process async events when warping the clock,
Pavel Dovgalyuk <=
- [Qemu-devel] [RFC PATCH v5 21/24] scripts/replay-dump.py: replay log dumper, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 23/24] replay: save vmstate of the asynchronous events, Pavel Dovgalyuk, 2018/01/23
- [Qemu-devel] [RFC PATCH v5 24/24] replay: don't drain/flush bdrv queue while RR is working, Pavel Dovgalyuk, 2018/01/23
- Re: [Qemu-devel] [RFC PATCH v5 00/24] replay additions, no-reply, 2018/01/23
- Re: [Qemu-devel] [RFC PATCH v5 00/24] replay additions, Pavel Dovgalyuk, 2018/01/30