Re: [Qemu-devel] [PULL 00/43] Add hppa-softmmu

[Peter Maydell]

On 22 January 2018 at 03:41, Richard Henderson
<address@hidden> wrote:
> This has some improvements to the patch set posted on Dec 28.
>
>   * Change cpu init as requested by Igor Mammedov.
>   * Add SMP support
>   * Add firmware image
>   * Implement qemu-specific pause and system reset insns.
>
>
> r~
>
>
> The following changes since commit b384cd95eb9c6f73ad84ed1bb0717a26e29cc78f:
>
>   Merge remote-tracking branch 
> 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-01-19 
> 16:35:25 +0000)
>
> are available in the Git repository at:
>
>   git://github.com/rth7680/qemu.git tags/pull-hppa-20180121
>
> for you to fetch changes up to 350e2a714ac8db559b255f9e8fe91c574f45df53:
>
>   hw/hppa: Add MAINTAINERS entry (2018-01-21 14:05:03 -0800)
>
> ----------------------------------------------------------------
> Add hppa-softmmu

Hi. Patchew is complaining that this doesn't build on some hosts:


/var/tmp/patchew-tester-tmp-z8zo58jf/src/target/sh4/op_helper.c: In
function ‘superh_cpu_do_unaligned_access’:
/var/tmp/patchew-tester-tmp-z8zo58jf/src/target/sh4/op_helper.c:31:5:
error: enumeration value ‘MMU_DEBUG_LOAD’ not handled in switch
[-Werror=switch]
     switch (access_type) {
     ^~~~~~

so I'm going to drop it from my to-process queue.

Also, the patchew coding style check seems to be showing a lot
of whitespace and similar nits which I don't think there's any
reason to have in new code. Could you also fix those, please?

thanks
-- PMM