[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/5] target/arm: Add ZCR_ELx
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/5] target/arm: Add ZCR_ELx |
Date: |
Tue, 23 Jan 2018 08:23:05 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/22/2018 07:53 PM, Richard Henderson wrote:
> +static const ARMCPRegInfo zcr_el1_reginfo = {
> + .name = "ZCR_EL1", .state = ARM_CP_STATE_AA64,
> + .opc0 = 3, .opc1 = 0, .crn = 1, .crm = 2, .opc2 = 0,
> + .access = PL1_RW, .accessfn = zcr_access, .type = ARM_CP_64BIT,
> + .fieldoffset = offsetof(CPUARMState, vfp.zcr_el[1]),
> + .writefn = zcr_write, .raw_writefn = raw_write
> +};
Ho hum. Got far enough in the rest of my rebasing to see that .type must be
dropped -- there's an assert saying STATE_AA64 implies 64BIT and shouldn't be
repeated.
r~
- [Qemu-devel] [PATCH v3 0/5] target/arm: Preparatory work for SVE, Richard Henderson, 2018/01/22
- [Qemu-devel] [PATCH v3 2/5] target/arm: Add predicate registers for SVE, Richard Henderson, 2018/01/22
- [Qemu-devel] [PATCH v3 1/5] target/arm: Expand vector registers for SVE, Richard Henderson, 2018/01/22
- [Qemu-devel] [PATCH v3 3/5] target/arm: Add SVE to migration state, Richard Henderson, 2018/01/22
- [Qemu-devel] [PATCH v3 4/5] target/arm: Add ZCR_ELx, Richard Henderson, 2018/01/22
- [Qemu-devel] [PATCH v3 5/5] target/arm: Add SVE state to TB->FLAGS, Richard Henderson, 2018/01/22