[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 2/2] make: fix help message reference to bogu
|
From: |
Marc-Andre Lureau |
|
Subject: |
Re: [Qemu-devel] [PATCH v1 2/2] make: fix help message reference to bogus V=0 variable |
|
Date: |
Tue, 23 Jan 2018 18:05:23 +0100 |
On Tue, Jan 23, 2018 at 5:47 PM, Daniel P. Berrange <address@hidden> wrote:
> The make rules for building QEMU are mostly silent by default. They can
> be made verbose by setting the variable V=1. The default state does not
> however correspond to a V=0 setting - $(V) must be undefined / empty to
> get the default quiet build.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
(with that, qemu build-sys differs from automake & kernel at least)
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index c263190b8d..554ba69ced 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -940,4 +940,5 @@ ifdef QEMU_GA_MSI_ENABLED
> endif
> @echo ''
> endif
> - @echo ' $(MAKE) V=0|1 [targets] 0 => quiet build (default), 1 =>
> verbose build'
> + @echo ' $(MAKE) [targets] (quiet build, default)'
> + @echo ' $(MAKE) V=1 [targets] (verbose build)'
> --
> 2.14.3
>